Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#10245 closed (fixed)

All Authentication built in views assume that default templates and paths are used

Reported by: sfgreenwood Owned by: jacob
Component: Documentation Version: 1.0
Severity: Keywords: auth, built-in views
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documentation for the built in views in the Authentication battery, such as django.contrib.auth.views.password_change() says that the only optional argument is template_name if not using the default. Using a different template_name causes a NoReverseMatch error. Looking at the code, there is a second argument, post_change_redirect, which has to be defined if a different path from the default is used. Other, similar arguments apply to password_reset() for post_reset_redirect and email_template_name. These additional arguments should be documented. I would suggest that ideally there should no defaults at all and the paths and templates should be defined in settings.py or in a separate configuration file.

Change History (5)

comment:1 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:2 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 6 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from new to assigned

comment:4 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

comment:18 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top