Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#9518 closed (fixed)

Wrong JSON snippet on fixture documentation

Reported by: claude@… Owned by: jacob
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

On http://docs.djangoproject.com/en/dev/howto/initial-data, the JSON fixture example is wrong. Unlike Python, JSON doesn't allow commas after last element of a list or a dict.

The right example should be:

[
  {
    "model": "myapp.person",
    "pk": 1,
    "fields": {
      "first_name": "John",
      "last_name": "Lennon"
    }
  },
  {
    "model": "myapp.person",
    "pk": 2,
    "fields": {
      "first_name": "Paul",
      "last_name": "McCartney"
    }
  }
]

Attachments (1)

9518.diff (304 bytes) - added by ramiro 6 years ago.
Trivial patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by claude@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Moreover, you can quickly check the syntax on http://www.jslint.com/

comment:2 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [9355]) Fixed #9518 -- Corrected example JSON snippet in fixture documentation. Thanks to claude@… for the report.

comment:3 Changed 6 years ago by russellm

(In [9356]) [1.0.X] Fixed #9518 -- Corrected example JSON snippet in fixture documentation. Thanks to claude@… for the report.

Merge of [9355] from trunk.

comment:4 Changed 6 years ago by hheimbuerger

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, still incorrect. As shown in claude@…'s correction, the outer list may not have a comma at the end either.

The last two lines have to be

  }
]

not

  },
]

comment:5 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by ramiro

Trivial patch

comment:6 Changed 6 years ago by ramiro

  • Has patch set

comment:7 Changed 6 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from reopened to assigned

comment:8 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

comment:18 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top