#19528 closed Bug (invalid)
CachedFilesMixin does not rewrite rules for css selector with path
| Reported by: | Owned by: | Jason Novinger | |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | 1.4 |
| Severity: | Normal | Keywords: | CachedFilesMixin staticfiles djbday |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Using CachedFilesMixin we'll have paths like this
<img alt="True" src="/media/static/admin/img/icon-yes.0596085e212f.gif">
after template rendering, but an unmodified selector:
img[src$="admin/img/icon-yes.gif"] in processed stylesheet.
This happens because CachedFilesMixin.patterns does not contain a rule like this """(img\[src[\^\$\*]{0,1}=\s*["']\s*(.*?)["'])""" to match against and actually can not deal with ^=|$=|*= operators. I am not sure how such paths can be properly processed, though.
Change History (4)
comment:1 Changed 11 years ago by
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 Changed 8 years ago by
| Owner: | changed from nobody to Jason Novinger |
|---|---|
| Status: | new → assigned |
comment:3 Changed 8 years ago by
| Keywords: | djbday added |
|---|
comment:4 Changed 4 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | assigned → closed |
This issue is not valid anymore because CachedFilesMixin and CachedStaticFilesStorage will be removed in Django 3.1 (see f1894bae3071da4ee577fc40ae61491f3e03d82c) and an eventual patch doesn't qualify for a backport.
Note: See
TracTickets for help on using
tickets.
Totally out of my expertise area, but seems valid.