Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10359 closed (fixed)

Feed class reference contains false info

Reported by: minder Owned by: jacob
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://docs.djangoproject.com/en/dev/ref/contrib/syndication/#feed-class-reference

I noticed this when I tried to make feed from objects that do not have get_absolute_url method (short messages for frontpage that don't need to have their own pages). I wrote item_link so that it points to the page that displayed recent messages but it turned out, that the feed readers were displaying only the last message - both rss and atom. It turned out this was caused by the lack of unique id for each item in the feed.

The only way to make unique ids I could find in the docs was item_guid method (it returns obj.id in my case) but the docs clearly state that this method is only used in atom feeds. It is not. I tried it with RSS feed and it worked.

Attachments (1)

10359.patch (707 bytes) - added by peterbe 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by peterbe

  • Resolution set to fixed
  • Status changed from new to closed

I've checked. The item_guid() is used by the Feed class just like it works for feed_type = Atom1Feed. So, not a feature just for Atom feeds like it said in the comment in the documentation.
Patch attached.

Changed 5 years ago by peterbe

comment:3 Changed 5 years ago by russellm

  • Resolution fixed deleted
  • Status changed from closed to reopened

Not fixed until the patch is applied.

comment:4 Changed 5 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from reopened to assigned

comment:5 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

comment:18 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.