Missing syntax highlighting in view code snippets in formset documentation

[Paul Menzel <paulepanter@…>]

Dear developers,

there is no syntax highlighting in the first code snippet for an example view in [1].

Thanks,

Paul

[1] ​http://docs.djangoproject.com/en/dev/topics/forms/formsets/#using-a-formset-in-views-and-templates

[Paul Menzel <paulepanter@…>]

Dear developers,

the same is the case in [2].

Thanks,

Paul

[2] ​http://docs.djangoproject.com/en/dev/topics/forms/formsets/#using-more-than-one-formset-in-a-view

[Paul Menzel <paulepanter@…>]

Dear developers,

I am going to just add more links to section were the code is not syntax highlighted.

Thanks,

Paul

​http://docs.djangoproject.com/en/dev/topics/auth/#authentication-in-web-requests

​http://docs.djangoproject.com/en/dev/topics/auth/#django.contrib.auth.login

[Tim Graham]

Looks like the syntax highlighting is failing due to the if/else statements that only have comments nested in them instead of actual python code.

example:

if formset.is_valid():
  # do something with the formset.cleaned_data

[Paul Menzel <paulepanter@…>]

Dear Developers,

ok seems to be something generic. I just post some more links I found.

Thanks,

Paul

​http://docs.djangoproject.com/en/dev/topics/db/models/#many-to-one-relationships

​http://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.ForeignKey

​http://www.djangoproject.com/documentation/models/one_to_one/

[Matt Boersma]

Patch to turn on code highlighting for two sections in the topics/auth document

[Tim Graham]

Does the patch actually highlight the code when you build it, mboersma? I tried applying your patch and it doesn't highlight the text. Like I said before, I think this issue has to do with the syntax highlighting parser failing due to what is technically invalid python (when a comment is used to describe what to do instead of writing python statements).

[Manuel Kaufmann]

I found a good description for this in ​http://bitbucket.org/birkenfeld/sphinx/src/bfda544c3193/doc/markup/code.rst (Line 32), it says that if the python code is invalid it will not be highlighted. So, when the code is interpret, the comments are deleted and then the code is invalid.

If you add pass below the line that contains the comment, it disappear. I can't find how to disable this option in Sphinx.

[Jacob]

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

[Jacob]

Milestone 1.1 deleted