Opened 6 years ago

Closed 4 years ago

#9771 closed (wontfix)

Wrong form action

Reported by: tutonien Owned by: jacob
Component: Documentation Version: 1.0
Severity: Keywords: tutorial, form, post, action, absolute
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hello,

There may be an improvement in the form of the fourth part of the tutorial.

The form sends the vote to /polls/123/vote/ (with 123 the poll id) but the form itself is in the detail page which URL is /polls/123/. Therefore, it would make more sense to use a relative URL instead of an absolute one.

<form action="/polls/{{ poll.id }}/vote/" method="post">

This way, the poll app would be more "pluggable" because the polls directory does not need to be at the root of the server.

<form action="vote/" method="post">

Thank you for your time and your good work.

Change History (6)

comment:1 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from new to assigned

comment:3 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

comment:4 Changed 6 years ago by kmtracey

Note this change broke the error path through the associated view. See #10801.

comment:5 Changed 6 years ago by russellm

  • milestone 1.1 deleted
  • Resolution fixed deleted
  • Status changed from closed to reopened

(In [10973]) Fixed #10801 -- Reverted a portion of [10371]. Practicality beats purity in this case. Thanks to bruce@… for the report. Refs #9771.

comment:6 Changed 4 years ago by gabrielhurley

  • Resolution set to wontfix
  • Status changed from reopened to closed

I'm in agreement with the assessment that practicality wins in this instance. The tutorial should be simple, understandable, and "just work".

If you want to make your app pluggable you need to be using the {% url %} tag and/or get_absolute_url to be getting these attributes dynamically, which is outside the current scope of the tutorial. Using a hard-coded relative path is (IMHO) just as bad as using a less-pluggable absolute path. It's already been proven to be just as fraught with error.

If someone wants to suggest that the tutorial cover named views and using the {% url %} tag then a new ticket should be opened for it.

As such, I'm closing this as a wontfix.

Note: See TracTickets for help on using tickets.
Back to Top