Opened 8 years ago

Closed 7 years ago

#5817 closed (fixed)

Support inheritance for model option classes

Reported by: miracle2k Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: qs-rf-fixed
Cc: Triage Stage: Fixed on a branch
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This currently is not possible:

class BaseMeta(object):
    app_label = "myapp"

class Company(models.Model):
    class Meta(BaseMeta):
        pass

The reason is that db.models.options.Options.contribute_to_class() uses __dict__ to determine which attributes have been given. It attempts to delete from __dict__, which apparently is not allowed for new-style classes, but __dict__ will not include attributes of superclasses anyway.

I attached a simple patch that uses dir() instead - if been using it for a while and there don't seem to be any problems.

Note that the patch will *not* allow custom meta attributes by prefixing them with __:

metakritik.site: 'class Meta' got invalid attribute(s): _BaseMeta__myopt

Attachments (1)

model_meta_w_inheritance.diff (963 bytes) - added by miracle2k 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by miracle2k

comment:1 Changed 8 years ago by jacob

  • Keywords qs-rf-fixed added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Fixed on a branch

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7477]) Merged the queryset-refactor branch into trunk.

This is a big internal change, but mostly backwards compatible with existing
code. Also adds a couple of new features.

Fixed #245, #1050, #1656, #1801, #2076, #2091, #2150, #2253, #2306, #2400, #2430, #2482, #2496, #2676, #2737, #2874, #2902, #2939, #3037, #3141, #3288, #3440, #3592, #3739, #4088, #4260, #4289, #4306, #4358, #4464, #4510, #4858, #5012, #5020, #5261, #5295, #5321, #5324, #5325, #5555, #5707, #5796, #5817, #5987, #6018, #6074, #6088, #6154, #6177, #6180, #6203, #6658

Note: See TracTickets for help on using tickets.
Back to Top