Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13134 closed (fixed)

Updated hebrew translations

Reported by: mksoft Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: shai Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

See the attached diff for updated hebrew translations

Attachments (4)

django_hebrew_translation.diff (85.5 KB) - added by mksoft 4 years ago.
django_hebrew_translation.2.diff (91.5 KB) - added by shai 4 years ago.
some more updates
django_hebrew_mksoft.diff (20.0 KB) - added by shai 4 years ago.
diff against file with previous patch applied
django_hebrew_translation+js.diff (105.6 KB) - added by shai 4 years ago.
New version

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by mksoft

comment:1 Changed 4 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

LGTM

Changed 4 years ago by shai

some more updates

Changed 4 years ago by shai

diff against file with previous patch applied

comment:2 Changed 4 years ago by shai

  • Cc shai added

Hi,

I've updated the patch, and also posted a file showing my changes against mksoft's updates for easy review.

I'm not sure if a new patch should change the Triage Stage; I expect this is still in time for 1.2 either way.

Thanks,

Shai.

comment:3 Changed 4 years ago by russellm

@shai Translations are a bit of a special case - As long as the patch applies, they're RFC by definition.

Changed 4 years ago by shai

New version

comment:4 Changed 4 years ago by shai

The new diff file just attached includes updates to both django.po and djangojs.po to match updated code.

In accordance with discussions on the django-il list, this also includes:

  • Use of תבנית instead of תחביר for "format" all over the place
  • Use of the ־ (Hebrew-punctuation-maqaf) character
  • Some other minor corrections.

comment:5 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [13049]) Fixed #13134 - Updated Hebrew translation. Thanks, Shai Berger.

comment:6 Changed 4 years ago by shai

Curse non-working mail notifications. For the record, most credit here is due to Meir Kriheli (mksoft).

comment:7 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.