Code

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9959 closed (fixed)

Documentation Comments Framework

Reported by: msm Owned by: nobody
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hello,

I think there's a small typo in http://docs.djangoproject.com/en/dev/ref/contrib/comments/#rendering-a-custom-comment-form

To really get a preview in the example the value of the name attribute of the input element should be changed:

from:

{% get_comment_form for event as form %}
<form action="{% comment_form_target %}" method="POST">
  {{ form }}
  <p class="submit">
    <input type="submit" name="submit" class="submit-post" value="Preview">
  </p>
</form>

to:

{% get_comment_form for event as form %}
<form action="{% comment_form_target %}" method="POST">
  {{ form }}
  <p class="submit">
    <input type="submit" name="preview" class="submit-post" value="Preview">
  </p>
</form>

Attachments (1)

9959.diff (554 bytes) - added by thejaswi_puthraya 5 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by thejaswi_puthraya

git-patch against the latest checkout

comment:1 Changed 5 years ago by thejaswi_puthraya

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [9731]) Fixed #9959: fixed comment documentation example showing how to get a preview.

comment:3 Changed 5 years ago by jacob

(In [9738]) A handful of fixes to django.contrib.comments:

comment:4 Changed 5 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.