Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#9429 closed (fixed)

Comment.get_as_text returns no information about non-authenticated users

Reported by: Kjell Magne Fauske Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: comments username anonymous
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The get_as_text method in django.contrib.comments.models.Comments uses the self.user field when inserting information about the commenter. This field will be set to None for non-authenticated users. The name property should be used instead since it checks that a user is authenticated or not and returns the correct name in both cases.

Attachments (1)

9429.diff (541 bytes) - added by thejaswi_puthraya 7 years ago.
git-patch against latest checkout

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by thejaswi_puthraya

git-patch against latest checkout

comment:1 Changed 7 years ago by thejaswi_puthraya

  • Has patch set
  • Keywords comments username anonymous added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Version set to SVN

comment:2 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [9730].

comment:3 Changed 6 years ago by jacob

(In [9738]) A handful of fixes to django.contrib.comments:

Note: See TracTickets for help on using tickets.
Back to Top