Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#9429 closed (fixed)

Comment.get_as_text returns no information about non-authenticated users

Reported by: Kjell Magne Fauske Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords: comments username anonymous
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

The get_as_text method in django.contrib.comments.models.Comments uses the self.user field when inserting information about the commenter. This field will be set to None for non-authenticated users. The name property should be used instead since it checks that a user is authenticated or not and returns the correct name in both cases.

Change History (4)

by Thejaswi Puthraya, 16 years ago

Attachment: 9429.diff​ added

git-patch against latest checkout

comment:1 by Thejaswi Puthraya, 16 years ago

Has patch: set
Keywords: comments username anonymous added
Triage Stage: Unreviewed → Accepted
Version: → SVN

comment:2 by Jacob, 16 years ago

Resolution: → fixed
Status: new → closed

Fixed in [9730].

comment:3 by Jacob, 16 years ago

(In [9738]) A handful of fixes to django.contrib.comments:

Note: See TracTickets for help on using tickets.
Back to Top