Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9346 closed (fixed)

Comments upgrading page has wrong SQL in it

Reported by: seemant Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: comments, documentation
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://docs.djangoproject.com/en/dev/ref/contrib/comments/upgrade/ has some SQL to help you go to the new comments model in 1.0. However, the mapping is from 'is_removed' to 'approved'. Surely, the mapping shouldn't be direct, but rather inverted? In other words, if it's removed, it should be NOT approved. Or, is it that 'approved' is misnamed as a field?

Attachments (1)

upgrade_freecomments.txt (580 bytes) - added by mt 7 years ago.
patch to fix freecomments upgrade

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by mt

patch to fix freecomments upgrade

comment:1 Changed 7 years ago by anonymous

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by thejaswi_puthraya

  • Component changed from Uncategorized to Documentation
  • Keywords comments documentation added
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.0 to SVN

Well, as you pointed out it should be an inverted mapping...my bad.

comment:3 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [9732]) Fixed #9346: fixed comment upgrade SQL in documentation. Thanks, mt.

comment:4 Changed 7 years ago by jacob

(In [9738]) A handful of fixes to django.contrib.comments:

Note: See TracTickets for help on using tickets.
Back to Top