#9346 closed (fixed)
Comments upgrading page has wrong SQL in it
| Reported by: | Seemant Kulleen | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Keywords: | comments, documentation | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
http://docs.djangoproject.com/en/dev/ref/contrib/comments/upgrade/ has some SQL to help you go to the new comments model in 1.0. However, the mapping is from 'is_removed' to 'approved'. Surely, the mapping shouldn't be direct, but rather inverted? In other words, if it's removed, it should be NOT approved. Or, is it that 'approved' is misnamed as a field?
Attachments (1)
Change History (5)
by , 16 years ago
| Attachment: | upgrade_freecomments.txt added |
|---|
comment:1 by , 15 years ago
| Has patch: | set |
|---|
comment:2 by , 15 years ago
| Component: | Uncategorized → Documentation |
|---|---|
| Keywords: | comments documentation added |
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.0 → SVN |
Well, as you pointed out it should be an inverted mapping...my bad.
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
patch to fix freecomments upgrade