Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#9345 closed Uncategorized (wontfix)

Various string consistency fixes

Reported by: Semmel Owned by: nobody
Component: Uncategorized Version: 1.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

Corrected the spelling of e-mail throughout the code and fixed a few associated whitespace issues. I also did some small changes to comments to make the translation strings more consistent with django core.

Attachments (2)

fixes.patch (22.0 KB) - added by Semmel 7 years ago.
fixes_new.patch (22.0 KB) - added by Semmel 6 years ago.

Download all attachments as: .zip

Change History (16)

Changed 7 years ago by Semmel

comment:1 Changed 7 years ago by Semmel

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Please view http://docs.djangoproject.com/en/dev/internals/contributing/ "Commonly used terms" - just in case. ;)

comment:2 Changed 7 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from new to assigned

comment:3 Changed 7 years ago by mtredinnick

@jezdez: why is this assigned to you? Are you doing more work on it, or is there something else to look at?

Not rushing you if there's something you want to do, but I'm wondering if there's something left to do beyond proof-read and check in.

comment:4 Changed 7 years ago by jezdez

@mtredinnick: Err, very good question. IIRC Semmel reported it first in #django-de while I was working on translation.

The patch looks ok but may need to be updated to current trunk. It'll change a lot strings, which hopefully will be recognized by gettext automatically.

@Semmel: Let me know if you need help updating this.

comment:5 Changed 6 years ago by Semmel

I don't understand the problem. The code hasn't changed at all at the relevant places (actually it has - but that doesn't affect it) so the patch is still valid and produces the same output as before. But for your convenience i'll add an up-to-date patch based on the actual revision. :)

Changed 6 years ago by Semmel

comment:6 Changed 6 years ago by jezdez

  • Owner changed from jezdez to Semmel
  • Status changed from assigned to new

comment:7 Changed 6 years ago by Semmel

  • Triage Stage changed from Unreviewed to Ready for checkin

Oh please, can we just check it in? It's not magic or anything, just a few textual consistency issues.

comment:8 Changed 6 years ago by jezdez

While I agree with you I have to remind you that it changes quite a few i18n strings.

comment:9 Changed 6 years ago by Semmel

  • Owner changed from Semmel to nobody
  • Triage Stage changed from Ready for checkin to Design decision needed

I'll change the status so that someone will look into it.

comment:10 Changed 6 years ago by mtredinnick

  • Triage Stage changed from Design decision needed to Accepted

Please don't change the status just to try and get attention to the ticket. It will be attended to in due course.

It does need some review, since some of the changes seems a bit surperfluous (e.g. capitalising one word alt tags), but it doesn't need a design decision.

comment:11 Changed 6 years ago by Semmel

Sorry, it just seemed like some kind of design decision is needed here because it takes so long for so few strings. It personally don't see these superfluous changes but i'll be open to suggestions from your side. Just change it as needed. :)

comment:12 Changed 4 years ago by julien

  • Resolution set to wontfix
  • Severity set to Normal
  • Status changed from new to closed
  • Type set to Uncategorized

Wontfixing since "email" (without hyphen) is now the new preferred way as of r15967.

comment:13 follow-up: Changed 4 years ago by Semmel

  • Easy pickings unset

"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?

comment:14 in reply to: ↑ 13 Changed 4 years ago by julien

Replying to Semmel:

"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?

I think it's a bit confusing to have a patch addressing multiple inconsistencies in multiple places. It will be easier if you create separate tickets for each chunk of related issues.

Note: See TracTickets for help on using tickets.
Back to Top