#9345 closed Uncategorized (wontfix)
Various string consistency fixes
Reported by: | Florian Sening | Owned by: | nobody |
---|---|---|---|
Component: | Uncategorized | Version: | 1.0 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Corrected the spelling of e-mail throughout the code and fixed a few associated whitespace issues. I also did some small changes to comments to make the translation strings more consistent with django core.
Attachments (2)
Change History (16)
by , 16 years ago
Attachment: | fixes.patch added |
---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 16 years ago
@jezdez: why is this assigned to you? Are you doing more work on it, or is there something else to look at?
Not rushing you if there's something you want to do, but I'm wondering if there's something left to do beyond proof-read and check in.
comment:4 by , 16 years ago
@mtredinnick: Err, very good question. IIRC Semmel reported it first in #django-de while I was working on translation.
The patch looks ok but may need to be updated to current trunk. It'll change a lot strings, which hopefully will be recognized by gettext automatically.
@Semmel: Let me know if you need help updating this.
comment:5 by , 16 years ago
I don't understand the problem. The code hasn't changed at all at the relevant places (actually it has - but that doesn't affect it) so the patch is still valid and produces the same output as before. But for your convenience i'll add an up-to-date patch based on the actual revision. :)
by , 16 years ago
Attachment: | fixes_new.patch added |
---|
comment:6 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
comment:7 by , 16 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
Oh please, can we just check it in? It's not magic or anything, just a few textual consistency issues.
comment:8 by , 16 years ago
While I agree with you I have to remind you that it changes quite a few i18n strings.
comment:9 by , 16 years ago
Owner: | changed from | to
---|---|
Triage Stage: | Ready for checkin → Design decision needed |
I'll change the status so that someone will look into it.
comment:10 by , 16 years ago
Triage Stage: | Design decision needed → Accepted |
---|
Please don't change the status just to try and get attention to the ticket. It will be attended to in due course.
It does need some review, since some of the changes seems a bit surperfluous (e.g. capitalising one word alt tags), but it doesn't need a design decision.
comment:11 by , 16 years ago
Sorry, it just seemed like some kind of design decision is needed here because it takes so long for so few strings. It personally don't see these superfluous changes but i'll be open to suggestions from your side. Just change it as needed. :)
comment:12 by , 14 years ago
Resolution: | → wontfix |
---|---|
Severity: | → Normal |
Status: | new → closed |
Type: | → Uncategorized |
Wontfixing since "email" (without hyphen) is now the new preferred way as of r15967.
follow-up: 14 comment:13 by , 14 years ago
Easy pickings: | unset |
---|
"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?
comment:14 by , 14 years ago
Replying to Semmel:
"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?
I think it's a bit confusing to have a patch addressing multiple inconsistencies in multiple places. It will be easier if you create separate tickets for each chunk of related issues.
Please view http://docs.djangoproject.com/en/dev/internals/contributing/ "Commonly used terms" - just in case. ;)