#9345 closed Uncategorized (wontfix)
Various string consistency fixes
Reported by: | Florian Sening | Owned by: | nobody |
---|---|---|---|
Component: | Uncategorized | Version: | 1.0 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Corrected the spelling of e-mail throughout the code and fixed a few associated whitespace issues. I also did some small changes to comments to make the translation strings more consistent with django core.
Attachments (2)
Change History (16)
Changed 14 years ago by
Attachment: | fixes.patch added |
---|
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Owner: | changed from nobody to Jannis Leidel |
---|---|
Status: | new → assigned |
comment:3 Changed 14 years ago by
@jezdez: why is this assigned to you? Are you doing more work on it, or is there something else to look at?
Not rushing you if there's something you want to do, but I'm wondering if there's something left to do beyond proof-read and check in.
comment:4 Changed 14 years ago by
@mtredinnick: Err, very good question. IIRC Semmel reported it first in #django-de while I was working on translation.
The patch looks ok but may need to be updated to current trunk. It'll change a lot strings, which hopefully will be recognized by gettext automatically.
@Semmel: Let me know if you need help updating this.
comment:5 Changed 14 years ago by
I don't understand the problem. The code hasn't changed at all at the relevant places (actually it has - but that doesn't affect it) so the patch is still valid and produces the same output as before. But for your convenience i'll add an up-to-date patch based on the actual revision. :)
Changed 14 years ago by
Attachment: | fixes_new.patch added |
---|
comment:6 Changed 14 years ago by
Owner: | changed from Jannis Leidel to Florian Sening |
---|---|
Status: | assigned → new |
comment:7 Changed 14 years ago by
Triage Stage: | Unreviewed → Ready for checkin |
---|
Oh please, can we just check it in? It's not magic or anything, just a few textual consistency issues.
comment:8 Changed 14 years ago by
While I agree with you I have to remind you that it changes quite a few i18n strings.
comment:9 Changed 14 years ago by
Owner: | changed from Florian Sening to nobody |
---|---|
Triage Stage: | Ready for checkin → Design decision needed |
I'll change the status so that someone will look into it.
comment:10 Changed 14 years ago by
Triage Stage: | Design decision needed → Accepted |
---|
Please don't change the status just to try and get attention to the ticket. It will be attended to in due course.
It does need some review, since some of the changes seems a bit surperfluous (e.g. capitalising one word alt tags), but it doesn't need a design decision.
comment:11 Changed 14 years ago by
Sorry, it just seemed like some kind of design decision is needed here because it takes so long for so few strings. It personally don't see these superfluous changes but i'll be open to suggestions from your side. Just change it as needed. :)
comment:12 Changed 11 years ago by
Resolution: | → wontfix |
---|---|
Severity: | → Normal |
Status: | new → closed |
Type: | → Uncategorized |
Wontfixing since "email" (without hyphen) is now the new preferred way as of r15967.
comment:13 follow-up: 14 Changed 11 years ago by
Easy pickings: | unset |
---|
"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?
comment:14 Changed 11 years ago by
Replying to Semmel:
"email" seems to fit it better. :) Any use for the few other fixes that were included in the patch?
I think it's a bit confusing to have a patch addressing multiple inconsistencies in multiple places. It will be easier if you create separate tickets for each chunk of related issues.
Please view http://docs.djangoproject.com/en/dev/internals/contributing/ "Commonly used terms" - just in case. ;)