Opened 8 years ago

Closed 8 years ago

#9960 closed (wontfix)

Simple code cleanup in core/management/__init__.py

Reported by: Antti Rasinen Owned by: nobody
Component: Core (Other) Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The list comprehension in get_commands is downright hairy. It is possible to rewrite it as a simple for-loop, which clarifies the meaning. Patch attached.

Attachments (1)

list_incomprehension.diff (675 bytes) - added by Antti Rasinen 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by Antti Rasinen

Attachment: list_incomprehension.diff added

comment:1 Changed 8 years ago by Jacob

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: wontfix
Status: newclosed

This is one of those little tweaks that, while a fine change on the face of it, adds absolutely no value to Django and simply churns code for no good reason. So thanks for spotting our ugly code, but we'll fix it the next time we're in the area; there's no reason to make this change absent of a bug/feature.

Note: See TracTickets for help on using tickets.
Back to Top