Code

Opened 5 years ago

Closed 5 years ago

#9960 closed (wontfix)

Simple code cleanup in core/management/__init__.py

Reported by: arsatiki Owned by: nobody
Component: Core (Other) Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The list comprehension in get_commands is downright hairy. It is possible to rewrite it as a simple for-loop, which clarifies the meaning. Patch attached.

Attachments (1)

list_incomprehension.diff (675 bytes) - added by arsatiki 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by arsatiki

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

This is one of those little tweaks that, while a fine change on the face of it, adds absolutely no value to Django and simply churns code for no good reason. So thanks for spotting our ugly code, but we'll fix it the next time we're in the area; there's no reason to make this change absent of a bug/feature.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.