Code

Opened 6 years ago

Closed 6 years ago

#7902 closed (fixed)

/password_change/ is 404

Reported by: toke Owned by: nobody
Component: *.djangoproject.com Version:
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

After a password reset via: http://www.djangoproject.com/accounts/password/reset/ I got an e-mail which contains a link to http://www.djangoproject.com/password_change/ which returns 404.
A working link would be http://www.djangoproject.com/accounts/password/change/

Attachments (2)

password_email_link.diff (579 bytes) - added by Mnewman 6 years ago.
password_email_url.diff (611 bytes) - added by Bob Thomas <bthomas@…> 6 years ago.
Replace hardcoded link with url tag

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Mnewman

  • Component changed from Django Web site to Admin interface
  • Has patch set
  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

This is pretty straight forward, I added a patch for simplicity. This hard coded link should be replaced with a url tag, once that is possible.

Changed 6 years ago by Mnewman

comment:2 Changed 6 years ago by Bob Thomas <bthomas@…>

  • Cc bthomas@… added

{% url django.contrib.auth.views.password_change %} works on my site.

Changed 6 years ago by Bob Thomas <bthomas@…>

Replace hardcoded link with url tag

comment:3 Changed 6 years ago by toke

  • Component changed from Admin interface to Django Web site
  • milestone 1.0 deleted

The bug was reported against Django Web site not against admin, also admin is definitively wrong. Setting it back to Django Web site.

The template-problem is not in admin but just a missing password_reset_email.txt template in djangoproject website.

Bob Thomas approach using {% url django.contrib.auth.views.password_change %} in the contrib app template is ok and more generic.
An alternative would be to just add the corrected template to django_website/templates/registration/password_reset_email.txt

comment:4 Changed 6 years ago by Bob Thomas <bthomas@…>

This may be obsolete now, see ticket:8129

comment:5 Changed 6 years ago by bthomas

  • Cc bthomas@… removed

comment:6 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [8925]) [djangoproject.com] a bunch of fixes to the website. Fixes #7271, #7459, #7902, #8271, #7949, #8845.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.