Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8129 closed (fixed)

Modify password reset email template to allow user configured urls

Reported by: davenaff Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: richard.davies@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This line is currently used to generate password reset urls:

{{ protocol }}://{{ domain }}/reset/{{ uid }}-{{ token }}/

This creates a fixed url in every email sent, so the user cannot customize the URL.

The proposed change is to use this line instead:

{{ protocol }}://{{ domain }}{% url django.contrib.auth.views.password_reset_confirm uidb36=uid, token=token %}

This is a single line patch so I won't upload diff files, etc.

Attachments (1)

new_email.diff (691 bytes) - added by davenaff 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by jacob

  • Has patch unset
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Please do upload a diff; it makes the whole process quicker.

Changed 6 years ago by davenaff

comment:2 Changed 6 years ago by mattmcc

  • Has patch set

comment:3 Changed 6 years ago by mattmcc

#8451 is a dup, but also has a patch.

comment:4 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [8517]) Fixed #8129: Modified the password reset email template to use a URL lookup, so that the email doesn't require customization based on the way that the reset view is deployed. Thanks to davenaff for the report and fix.

comment:5 Changed 6 years ago by Richard Davies <richard.davies@…>

  • Cc richard.davies@… added

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.