Code

Opened 6 years ago

Closed 6 years ago

#7458 closed (fixed)

Lithuanian translation

Reported by: Rapolas Owned by: nobody
Component: Translations Version: master
Severity: Keywords: lithuanian lt translation l10n
Cc: Rapolas Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (2)

django.po (76.5 KB) - added by Rapolas@… 6 years ago.
Lithuanian translation
djangojs.po (3.2 KB) - added by Rapolas 6 years ago.
Lithuanian translation

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Rapolas@…

Lithuanian translation

comment:1 Changed 6 years ago by telenieko

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Are you willing to mantain Lithuanian in the future if this goes in?
Translations need constant mainteinance.

comment:2 follow-up: Changed 6 years ago by garcia_marc

  • Cc Rapolas added
  • Has patch set
  • Keywords lithuanian lt translation l10n added
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

First of all, thanks for the translation. You couldn't have a EuroPython without it... ;)

I've to comment some things about the patch:

Translation of djangojs.po is missing. And also are missing both translation compiled files (.mo).

Also for Django's policy, you should remove your name from the .po files, and add it at the end of authors file.

Finally, the correct way to submit a patch, is posting the result of a "svn diff" from your django root. It'll include all the changes you made.

comment:3 in reply to: ↑ 2 Changed 6 years ago by telenieko

Replying to garcia_marc:

Also for Django's policy, you should remove your name from the .po files, and add it at the end of authors file.

Not really, Malcolm usually compiles the .mo's to make sure .po == .mo

Changed 6 years ago by Rapolas

Lithuanian translation

comment:4 follow-up: Changed 6 years ago by Rapolas

Ok, I added djangojs.po file. As I understood from telenieko I don't need to make .mo files, correct me if I'm wrong ;) And I didn't get it, how to submit a patch, after doing svn diff, I got binary file, which posting here would be nonsense. Maybe I did something wrong...
By the way thanks for telling about EuroPython, I would missed it;)
And one more thing about maintaining, yes, I can do that, at least for now.

comment:5 in reply to: ↑ 4 Changed 6 years ago by telenieko

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Replying to Rapolas:

Ok, I added djangojs.po file. As I understood from telenieko I don't need to make .mo files

No worry ,they'll be compiled before commit.

how to submit a patch, after doing svn diff, I got binary file, which posting here would be nonsense. Maybe I did something wrong...

Sure, when you run svn diff you get the differences between your working copy nd the tree, given that you are diffing text files, you can't get binary differences. Maybe you are getting a text diff for the .po and a binary blob for the .po

Given it's a new translation there's not much problem on attaching .po files directly but for updates, try to do the svn diff after deleting the .mo to avoid having them in the diff.

And one more thing about maintaining, yes, I can do that, at least for now.

Thanks.

comment:6 Changed 6 years ago by telenieko

Oh, forgot to tell, try to join Django-i18n first step when contributing translations!

You'll se on those instructions that it's better to do the diff before checking the compile, to avoid the binary blob ;)

comment:7 Changed 6 years ago by telenieko

(In [7695]) Refs #7458, New Lithuanian translation. Thanks Rapolas Kaselis.

comment:8 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [7698]) Fixed #7458: added Lithuanian to LANGUAGES.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.