Attributes for Widgets composed of more than one HTML element

[Iwan Vosloo]

As suggested in #3870, I'm adding this ticket.

With widgets (such as {{RadioSelect}} or {{MultiWidget}}) that are rendered as several HTML elements/inputs one sometimes need a way to attach HTML attributes to the widget as a whole so that you can style its constituent parts using a stylesheet.

Please see the reason for this request in ​http://groups.google.com/group/django-developers/browse_thread/thread/e55be1c11893c069

A naïve implementation would be that if you construct the widget with attrs= keyword argument, they should be used as HTML attributes on a suitable element (as in #4080). It seems, however, as if the norm is as in #3870.

I believe a design decision is needed here: #4080 does one thing with attrs, #3870 does another thing with attrs. For general styling, I think #4080 is the way to go, but it appeared to me that #3870 makes sense in other cases. (For example if you want to set readonly attribute on the entire widget, it should be set on all inputs it is composed of).

-i

[Gary Wilson <gary.wilson@…>]

Please note that #4080 is a subset of what is asked for here and has a (slightly outdated) patch for fixing RadioSelect container attributes.

[Gary Wilson <gary.wilson@…>]

attributes for containers of RadioSelect and CheckboxSelectMultiple widgets

[Gary Wilson <gary.wilson@…>]

MultiWidget doesn't have a containing element so there is nothing to do there. CheckboxSelectMultiple was the only other widget I noticed besides RadioSelect that used a container element.

[Chris Beaven]

Gary, your patch sets the attributes on the lis as well as the containing ul for the RadioSelect but not the CheckboxSelectMultiple widget.

I'm not sure you need to set it on the lis, do you?

[jaywgraves@…]

for solving this for a RadioSelect widget see #4228

[Alex Gaynor]

Here's an up to date patch, it adds the id attr, however it causes one test error(not failure), which is a UnicodeDecodeError

[Alex Gaynor]

No more test failures

[Alex Gaynor]

This version only adds the id attr to the ul, there is a seperate ticket about making newforms more CSS friendsly so we can defer the rest of the attrs to that ticket.

[Collin Anderson]

Is #5851 a duplicate of this?

[Alex Gaynor]

Same patch, just updated to apply against forms

[Alex Gaynor]

It is with great regret that I say this will have to wait until after 1.0.

[(none)]

Milestone post-1.0 deleted

[patchhammer]

widget-ul-id.2.diff fails to apply cleanly on to trunk

[Aymeric Augustin]

Change UI/UX from NULL to False.

[anonymous]

I've created a pull request based on Alex's last patch.

Half of the work was already done in #19874.

[Baptiste Mispelon]

For some reason, trac decided i was spamming and it logged me out.

Sorry about the noise.

[Claude Paroz <claude@…>]

In c4186c2fec6f5418c81366a911792bf5295db494:

Fixed #4117: Apply id attribute to the outer <ul> of RadioSelect