Opened 10 years ago

Closed 10 years ago

#3870 closed (fixed)

a couple widgets not passing along attrs to render()

Reported by: Gary Wilson <gary.wilson@…> Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

RadioSelect is setting a local variable in its render() method without touching self.attrs:

attrs = attrs or {}

and MultiWidget doesn't touch self.attrs either before calling render() on each Widget.

Attachments (1)

3870.diff (1.4 KB) - added by Gary Wilson <gary.wilson@…> 10 years ago.
use self.build_attrs

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Gary Wilson <gary.wilson@…>

Attachment: 3870.diff added

use self.build_attrs

comment:1 Changed 10 years ago by Gary Wilson <gary.wilson@…>

Has patch: set
Needs tests: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 10 years ago by Gary Wilson <gary.wilson@…>

#4080 marked as duplicate. That ticket's patch also added the attributes to the <ul> produced by RadioFieldRenderer, but maybe that could be a separate ticket as that is a new feature, whereas this is a bug fix.

comment:3 Changed 10 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [5065]) Fixed #3870, Refs #3787 -- Fixed handling of widget attributes on RadioSelect and MultiWidget. In particular, handling of the id attribute has been fixed. Thanks to Gary Wilson and Max Derkachev.

Note: See TracTickets for help on using tickets.
Back to Top