Opened 12 years ago
Closed 12 years ago
#19874 closed Cleanup/optimization (fixed)
Add id to <ul> element in CheckboxSelectMultiple
| Reported by: | l3on | Owned by: | Baptiste Mispelon |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | bmispelon@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Please,
consider to add an ID to <ul> element in CheckboxSelectMultiple.
The patch attached fixes the problem (it's based on git/develop branch).
Thanks in advance!
Leo.
Attachments (1)
Change History (7)
by , 12 years ago
| Attachment: | widgets-add_id_to_CheckboxSelectMultiple.patch added |
|---|
comment:1 by , 12 years ago
| Component: | Documentation → Forms |
|---|
comment:2 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
Seems reasonable to me; the id is currently only used to construct per-option numbered IDs, it makes sense that the base ID would be applied to the container.
comment:3 by , 12 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
comment:4 by , 12 years ago
| Cc: | added |
|---|---|
| Has patch: | unset |
| Needs documentation: | unset |
| Needs tests: | unset |
| Owner: | changed from to |
| Status: | new → assigned |
| Version: | → master |
I upgraded the patch to use format_html instead of string interpolation.
I also fixed the test suite and added some documentation of the feature.
The pull request can be found there: https://github.com/django/django/pull/999
comment:5 by , 12 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:6 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
add id to CheckboxSelectMultiple