Opened 4 years ago

Closed 3 years ago

#19874 closed Cleanup/optimization (fixed)

Add id to <ul> element in CheckboxSelectMultiple

Reported by: l3on Owned by: bmispelon
Component: Forms Version: master
Severity: Normal Keywords:
Cc: bmispelon@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no



consider to add an ID to <ul> element in CheckboxSelectMultiple.

The patch attached fixes the problem (it's based on git/develop branch).

Thanks in advance!


Attachments (1)

widgets-add_id_to_CheckboxSelectMultiple.patch (580 bytes) - added by l3on 4 years ago.
add id to CheckboxSelectMultiple

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by l3on

add id to CheckboxSelectMultiple

comment:1 Changed 4 years ago by timo

  • Component changed from Documentation to Forms
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by carljm

  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Cleanup/optimization

Seems reasonable to me; the id is currently only used to construct per-option numbered IDs, it makes sense that the base ID would be applied to the container.

comment:3 Changed 4 years ago by oinopion

  • Needs documentation set
  • Needs tests set

comment:4 Changed 3 years ago by bmispelon

  • Cc bmispelon@… added
  • Has patch unset
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to bmispelon
  • Status changed from new to assigned
  • Version set to master

I upgraded the patch to use format_html instead of string interpolation.

I also fixed the test suite and added some documentation of the feature.

The pull request can be found there:

comment:5 Changed 3 years ago by claudep

  • Has patch set
  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 3 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 844fbc85c1d419ed7ecbb7208bd392c1770ea72d:

Fixed #19874: Apply id attribute to the outer <ul> of CheckboxSelectMultiple

Note: See TracTickets for help on using tickets.
Back to Top