wrong attribute naming in method BaseModelFormSet.save_existing

[Maxim Danilov]

django.forms.models.py rows 654-667

we have a three methods:

    def save_new(self, form, commit=True):
        """Save and return a new model instance for the given form."""
        return form.save(commit=commit)

    def save_existing(self, form, instance, commit=True):
        """Save and return an existing model instance for the given form."""
        return form.save(commit=commit)

    def delete_existing(self, obj, commit=True):
        """Deletes an existing model instance."""
        if commit:
            obj.delete()

in delete_existing we have an "obj"
in save_existing we have an "instance"
why it is so? where the difference?

For ModelFormset in admin Inline we have also other instance: parent object. I can expected this "instance (parent)" instead of current "object".

My opinion: attribute name "instance" in save_existing should be changed on "obj"

[Carlton Gibson]

Hey Maxim, OK, yes. Where it's called the argument is obj, so +1 to making it consistent.
Want to make the PR?

Thanks.

[Maxim Danilov]

Replying to Carlton Gibson:

Hey Maxim, OK, yes. Where it's called the argument is obj, so +1 to making it consistent.
Want to make the PR?

Thanks.

Yes Carlton. I want to try to made it.

[Baha Sdtbekov]

​PR

[GitHub <noreply@…>]

In 5f3c7b7e:

Fixed #34317 -- Renamed "instance" argument of BaseModelFormSet.save_existing() method.

[Maxim Danilov]

Replying to GitHub <noreply@…>:

In 5f3c7b7e:

Fixed #34317 -- Renamed "instance" argument of BaseModelFormSet.save_existing() method.

Mariusz Felisiak was faster than me :*-(

Thank you.

[Mariusz Felisiak]

Mariusz Felisiak was faster than me :*-(

Not me, I only merged PR prepared by Bakdolot.