#34316 closed Bug (fixed)
Visual regressions in admin's change password form
Reported by: | Mariusz Felisiak | Owned by: | Sarah Boyce |
---|---|---|---|
Component: | contrib.admin | Version: | 4.2 |
Severity: | Release blocker | Keywords: | |
Cc: | Tom Carrick, Sarah Boyce | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I noticed two visual regressions in 96a598356a9ea8c2c05b22cadc12e256a3b295fd:
- There is no gap before the "this form" link on the "Change user" form:
- Inputs are in the wrong place (as far as I'm aware
<div>...</div>
is missing around<label>
and<input>
) on the "Change password" form:
- Inputs are in the wrong place (as far as I'm aware
<div>...</div>
is missing around<label>
and<input>
) on the "Password change" form:
Attachments (3)
Change History (16)
by , 21 months ago
Attachment: | this_form_after.png added |
---|
by , 21 months ago
Attachment: | change_password_after.png added |
---|
by , 21 months ago
Attachment: | password_change_after.png added |
---|
comment:1 by , 21 months ago
Description: | modified (diff) |
---|
comment:2 by , 21 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 21 months ago
Cc: | added |
---|
comment:4 by , 21 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:5 by , 21 months ago
Has patch: | set |
---|---|
Owner: | changed from | to
comment:6 by , 21 months ago
Patch needs improvement: | set |
---|
comment:7 by , 21 months ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/16548