Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#34318 closed Cleanup/optimization (fixed)

Add a release note that makemessages no longer changes .po files when up to date.

Reported by: אורי Owned by: Sota Tabu
Component: Documentation Version: 4.1
Severity: Normal Keywords:
Cc: Ad Timmering Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I didn't find any documentation of #6106 in Django 4.1 release notes (Prevented makemessages from changing .po files when up to date). I think this should be documented.

Change History (18)

comment:1 by אורי, 21 months ago

Component: UncategorizedDocumentation

comment:2 by Tim Graham, 21 months ago

It looks like a bug fix, not a new feature. Why would you document it?

comment:3 by אורי, 21 months ago

It's a change after 15 years of updating this line every time makemessages was called. If it was a bug it wouldn't persist for 15 years.

comment:4 by אורי, 21 months ago

Also, Claude Paroz wrote: "IMHO this is clearly a wontfix issue, as jezdez stated. It is perfectly legitimate to update POT-Creation-Date each time a po file is updated.". So I don't think it was a bug.

comment:5 by Tim Graham, 21 months ago

Is it causing you problems? Should it be documented as a backward incompatible change? How would you document it?

comment:6 by אורי, 21 months ago

Yes, I ran make_messages and was surprised that no files have changed. I expected each .po file to have one line changed.

How would I document it? Something like "makemessages - .po files will not change if there is no change in translations. Formerly POT-Creation-Date was always updated."

comment:7 by Mariusz Felisiak, 21 months ago

I'm confused. We reopened #6106 after reaching a consensus on the mailing list. Moreover, you were in favor of #6106:

"I also find it annoying that one line changes always even if there are no changes in translations. I prefer the file not to change at all if nothing has changed."

and Claude summed up the discussion with:

"As the won't fixer person 11 years ago, I'm also more in favour of the change now, even if it changes a bit the meaning of POT-Creation-Date from "last time the pot file was updated" to "last time a change was detected in the pot file"."

comment:8 by Ad Timmering, 21 months ago

Cc: Ad Timmering added

comment:9 by אורי, 21 months ago

Hi Mariusz. I like this change and I'm not asking to revert it. I just think it should be documented in the Django release notes.

in reply to:  9 comment:10 by Mariusz Felisiak, 21 months ago

Summary: Django 4.1 release notes - document #6106Add a release note that makemessages no longer changes .po files when up to date.
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

Replying to אורי:

Hi Mariusz. I like this change and I'm not asking to revert it. I just think it should be documented in the Django release notes.

OK, a small release note won't hurt. Would you like to prepare a patch?

comment:11 by אורי, 21 months ago

I can't create the PR myself, but you can add under Internationalization (or Management Commands):

makemessages - .po files will not change if there is no change in translations. Formerly POT-Creation-Date was always updated.

comment:12 by Sota Tabu, 21 months ago

Owner: changed from nobody to Sota Tabu
Status: newassigned

comment:13 by Sota Tabu, 21 months ago

Has patch: set

comment:14 by Mariusz Felisiak, 21 months ago

Patch needs improvement: set

comment:15 by Mariusz Felisiak, 21 months ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:16 by Mariusz Felisiak <felisiak.mariusz@…>, 21 months ago

Resolution: fixed
Status: assignedclosed

In 3e9d4132:

Fixed #34318 -- Added release note for 4bfe8c0eec835b8eaffcda7dc1e3b203751a790a.

comment:17 by Mariusz Felisiak <felisiak.mariusz@…>, 21 months ago

In 8cc5caa1:

[4.2.x] Fixed #34318 -- Added release note for 4bfe8c0eec835b8eaffcda7dc1e3b203751a790a.

Backport of 3e9d413231edc29768cc7ca0427e63b19233f562 from main

comment:18 by Mariusz Felisiak <felisiak.mariusz@…>, 21 months ago

In 425c75f5:

[4.1.x] Fixed #34318 -- Added release note for 4bfe8c0eec835b8eaffcda7dc1e3b203751a790a.

Backport of 3e9d413231edc29768cc7ca0427e63b19233f562 from main

Note: See TracTickets for help on using tickets.
Back to Top