Opened 8 years ago

Closed 5 years ago

#6106 closed (wontfix)

make-messages.py should not touch POT-Creation-Date

Reported by: telenieko Owned by: ramiro
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Someday/Maybe
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi there,
When you run make-messages.py it changes POT-Creation-Date to now and leaves PO-Revision-Date alone.

Shouldn't it be just the opposite? Creation-Date should not be changed, while Revision Date should be set to now

Maybe I got it wrong anyway :)

Attachments (1)

6106-1.diff (2.0 KB) - added by ramiro 6 years ago.
Patch that preserves the POT-Creation-Date header of a .po file when makemessages applies the msguniq/msmerge process

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by mtredinnick

I have a feeling we should just be passing --omit-header to the xgettext invocation (like we do for the javascript case) in make-messages.py. Current behaviour is certainly a small problem.

I'd hold off writing a aptch for this until after #5522 is resolved, though, since Jannis is in the process of moving everything around.

comment:3 Changed 7 years ago by jezdez

Doesn't --omit-header just prevents the creation of " msgid "" " at the top of the file?

Changed 6 years ago by ramiro

Patch that preserves the POT-Creation-Date header of a .po file when makemessages applies the msguniq/msmerge process

comment:4 Changed 6 years ago by ramiro

  • Has patch set
  • Owner changed from nobody to ramiro
  • Status changed from new to assigned

comment:5 Changed 5 years ago by ramiro

  • milestone set to 1.2

comment:6 Changed 5 years ago by jezdez

  • milestone 1.2 deleted
  • Triage Stage changed from Accepted to Someday/Maybe

Hm, according to the gettext manual (http://www.gnu.org/software/gettext/manual/gettext.html#Header-Entry) POT-Creation-Date will be filled out by xgettext and PO-Revision-Date "by the PO file editor when you save the file". In other words: PO-Revision-Date doesn't have anything to do with collection/updating translation strings but with the actual translation by the translators, as in "When was this file revised last time?".

As long as we use the *.po files for the same purpose as *.pot files, POT-Creation-Date is the field that is updated automatically.

I'm changing this to someday/maybe since we shouldn't redefine the meaning of gettext's header fields.

comment:7 Changed 5 years ago by claudep

IMHO this is clearly a wontfix issue, as jezdez stated. It is perfectly legitimate to update POT-Creation-Date each time a po file is updated.

comment:8 Changed 5 years ago by claudep

  • Resolution set to wontfix
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.
Back to Top