id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
34317	wrong attribute naming in method BaseModelFormSet.save_existing	Maxim Danilov	Baha Sdtbekov	"django.forms.models.py rows 654-667

we have a three methods:


{{{
    def save_new(self, form, commit=True):
        """"""Save and return a new model instance for the given form.""""""
        return form.save(commit=commit)

    def save_existing(self, form, instance, commit=True):
        """"""Save and return an existing model instance for the given form.""""""
        return form.save(commit=commit)

    def delete_existing(self, obj, commit=True):
        """"""Deletes an existing model instance.""""""
        if commit:
            obj.delete()
}}}

in **delete_existing** we have an ""''obj''""
in **save_existing** we have an ""''instance''""
why it is so? where the difference?

For **ModelFormset** in admin Inline we have also other instance: parent object. I can expected this ""instance (parent)"" instead of current ""object"". 

My opinion: attribute name  ""''instance''"" in **save_existing** should be changed on ""''obj''"""	Cleanup/optimization	closed	Forms	dev	Normal	fixed	Formset, ModelFomset		Ready for checkin	1	0	0	0	0	0