build_rpm problems

[Dirk Datzert <dummy@…>]

I build Django rpms on different python versions and different rpm versions.
I always struggled over the INSTALLED_FILES where directories not prefixed with %dir any longer.
This stopps some rpm build process to stop packaging since files under those directories resulted in an 'File listed twice' error.

A simple rpm_install-script will fix this.

[Dirk Datzert <dummy@…>]

rpm_install script and setup.cfg update

[Dirk Datzert <dummy@…>]

I forgot that MANIFEST.in needs to include docs and scripts

[Dirk Datzert <dummy@…>]

html-files and js/images etc also needs to be packed into sdist

[Gary Wilson <gary.wilson@…>]

combined patch

[Gary Wilson <gary.wilson@…>]

When I try running python setup.py bdist_rpm, I get the following error:

tar -cf dist/Django-0.96-pre.tar Django-0.96-pre
gzip -f9 dist/Django-0.96-pre.tar
removing 'Django-0.96-pre' (and everything under it)
copying dist/Django-0.96-pre.tar.gz -> build/bdist.linux-i686/rpm/SOURCES
building RPMs
rpmbuild -ba --define _topdir /home/gdub/bzr/django/build_rpm-3338/build/bdist.linux-i686/rpm --clean build/bdist.linux-i686/rpm/SPECS/Django.spec
error: File /home/gdub/bzr/django/build_rpm-3338/build/bdist.linux-i686/rpm/SOURCES/Django-0.96_pre.tar.gz: No such file or directory
error: command 'rpmbuild' failed with exit status 1

It appears that the version set in the spec file is 0.96_pre, and can't file the tar file with this name. Instead it's getting named ./build/bdist.linux-i686/rpm/SOURCES/Django-0.96-pre.tar.gz. I've never built a python package into an RPM. Do you know what's going on here?

[Dirk Datzert <dummy@…>]

Replying to Gary Wilson <gary.wilson@gmail.com>:

When I try running python setup.py bdist_rpm, I get the following error:

tar -cf dist/Django-0.96-pre.tar Django-0.96-pre
gzip -f9 dist/Django-0.96-pre.tar
removing 'Django-0.96-pre' (and everything under it)
copying dist/Django-0.96-pre.tar.gz -> build/bdist.linux-i686/rpm/SOURCES
building RPMs
rpmbuild -ba --define _topdir /home/gdub/bzr/django/build_rpm-3338/build/bdist.linux-i686/rpm --clean build/bdist.linux-i686/rpm/SPECS/Django.spec
error: File /home/gdub/bzr/django/build_rpm-3338/build/bdist.linux-i686/rpm/SOURCES/Django-0.96_pre.tar.gz: No such file or directory
error: command 'rpmbuild' failed with exit status 1

It appears that the version set in the spec file is 0.96_pre, and can't file the tar file with this name. Instead it's getting named ./build/bdist.linux-i686/rpm/SOURCES/Django-0.96-pre.tar.gz. I've never built a python package into an RPM. Do you know what's going on here?

Yes, I can verify this. In the setup.py the version is build with hyphens '-', this works fine for sdist command, but this is not allowd in the version number syntax of an rpm. I run the setup.py with version build like this:

Index: setup.py
===================================================================
--- setup.py    (Revision 4386)
+++ setup.py    (Arbeitskopie)
@@ -33,7 +33,7 @@
         file_info[0] = '/PURELIB/%s' % file_info[0]

 # Dynamically calculate the version based on django.VERSION.
-version = "%d.%d-%s" % (__import__('django').VERSION)
+version = "0.95.4386"

 setup(
     name = "Django",

[Gary Wilson <gary.wilson@…>]

If underscore works with both, maybe we should change the version in setup.py to use an underscore instead of a hyphen. No matter the case, the attached patch fixes this ticket, so I'm marking as ready.

[Malcolm Tredinnick]

(In [4490]) Refs #3338 -- Partially fix rpm packaging problems. There is still one issue
remaining with how we construct the version numbers, but this change is useful
nonetheless. Patch from Dirk Datzert.

[Malcolm Tredinnick]

We still need to work out whether to change our version number of change the rpm packaging script to put the right tarball name in the SPEC file and replace hyphens with something else in the package name. I'm not sure about the right approach there at the moment. I've checked in the work so far, though.

[Gary Wilson <gary.wilson@…>]

The hyphen problem has no patch.

[Malcolm Tredinnick]

Making the title reflect the ticket contents.

[Malcolm Tredinnick]

(In [4912]) Fixed #3338, #3536, #3796 -- Fixed a bunch of setup and build problems in a
portable fashion. That took a *lot* longer to debug than I thought it would, so
let's try not to break it.

[John Anderson]

It appears that this is broken again in 1.1 beta 1.

[Alex Gaynor]

This bug was fixed 2 years ago, if you think there's a new issue open a new ticket.

[John Anderson]

For future reference, this has reopened in #9616.