Opened 18 years ago
Closed 18 years ago
#3337 closed (fixed)
[patch] newforms-fields better calls super(CLASS,self) instead class-method Field
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | super | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I looked into django.newforms.fields and saw that in the init() and the clean() method always calls to the Field.init() and Field.clean() method are made.
In an more object oriented way those calls should be better super(CLASSNAME, self).init() and super(CLASSNAME, self).clean()
Attachments (2)
Change History (4)
by , 18 years ago
Attachment: | newforms-fields-super.diff added |
---|
by , 18 years ago
Attachment: | newforms-fields-super.2.diff added |
---|
fixed errors in the call of super(CLASSNAME, self)
comment:2 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
call super() instead Field-class-methods