Opened 4 years ago

Closed 3 years ago

#14967 closed Bug (wontfix)

django.contrib.auth.admin.UserAdmin.response_add changed in 1.2.4

Reported by: jonas.obrist@… Owned by: nobody
Component: Documentation Version: 1.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Changeset http://code.djangoproject.com/changeset/14628 introduced a change to UserAdmin.response_add which snuck into the 1.2.4 bugfix release of Django changing an existing API, which is not documented in the release notes of the security fix 1.2.4.

Change History (6)

comment:1 Changed 4 years ago by ramiro

  • Component changed from Authentication to Documentation
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from dajngo.contrib.auth.admin.UserAdmin.response_add changed in 1.2.4 to django.contrib.auth.admin.UserAdmin.response_add changed in 1.2.4
  • Triage Stage changed from Unreviewed to Accepted

First, a bit of background: r14629 fixed #14679 (I forgot to link the ticket in the commit message, sorry) that reported an unintended change in behavior introduced in r13503, that fixed #14014, that reported an unintended change in behavior introduced before the 1.2 release (r12218).

I see you point because, from an user POV, this is a behavior that changed during in 1.2.X branch life cycle, but OTOH it's buggy behavior that got corrected (hopefully for good after two commits) so a) all the buttons in the user add form do what their labels say, and b) they redirect to sensible pages after they are pressed just like they did in 1.1.

And yes, the 1.2.4 release has been triggered by a security fix, but our policy has always been that maintenance releases also fix other issues (I count aprox. 280 fixes of all kinds between 1.2.3 and 1.2.4).

Not sure I agree with you this is a change of an existing API, and I can see a release note could be of help.

comment:2 Changed 4 years ago by jonas.obrist@…

Thank you very much for the clarification.

comment:3 Changed 4 years ago by anonymous

  • Severity set to Normal
  • Type set to Bug

comment:4 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 3 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 3 years ago by aaugustin

  • Resolution set to wontfix
  • Status changed from new to closed

Since we no longer support 1.2 I think we can abandon this ticket.

Note: See TracTickets for help on using tickets.
Back to Top