Opened 6 years ago

Closed 17 months ago

#14968 closed Bug (needsinfo)

handle BaseExceptions with middleware, or at least KeyboardInterrupt

Reported by: Alexander Schepanovski Owned by: Alexander Schepanovski
Component: Core (Other) Version: 1.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

I was trying to write a middleware which shows a 503 page on KeyboardInterrupt (which happens on django restart) and run into this.
If it is not handled some unlucky users get 500 error page and search bots go away for a while.

Attachments (1)

catch_base_exception.diff (643 bytes) - added by Alexander Schepanovski 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by Alexander Schepanovski

Attachment: catch_base_exception.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

BaseException was introduced in Python 2.5, and Django needs to support Python 2.4 (at least for now).

Patch needs to be updated to support the exception class heirarchy in Python 2.4, as well as Python 2.5+

comment:2 Changed 6 years ago by anonymous

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:5 Changed 17 months ago by Tim Graham

Resolution: needsinfo
Status: newclosed

I don't understand the purpose of this change and there's been no activity in 5 years. Feel free to reopen with an explanation and an updated patch.

Note: See TracTickets for help on using tickets.
Back to Top