Opened 5 years ago

Last modified 8 months ago

#14129 new Bug

Slovenian translation plural-forms

Reported by: gasperzejn Owned by: jezdez
Component: Internationalization Version: 1.2
Severity: Normal Keywords:
Cc: diegobz@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Adds translation for [13502] and also fixes the wrong plurals equation.

Attachments (2)

django-i18n-sl-1.2.x.patch (32.3 KB) - added by gasperzejn 5 years ago.
Updated diff of django.po
14129.diff (10.6 KB) - added by claudep 4 years ago.
Only plural forms changed

Download all attachments as: .zip

Change History (21)

Changed 5 years ago by gasperzejn

Updated diff of django.po

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 5 years ago by claudep

  • Summary changed from Updated Slovenian translation for 1.2.x to Fix Slovenian translation plural-forms
  • Triage Stage changed from Ready for checkin to Accepted

Django translations are now done through the Transifex project.

You will find all required information on the Django documentation website:

http://docs.djangoproject.com/en/dev/internals/contributing/#submitting-and-maintaining-translations

I'm just letting the bug open for the plural-form change. We need to check if it is feasible through Transifex.

comment:3 Changed 4 years ago by gasperzejn

  • Resolution set to invalid
  • Status changed from new to closed

Uh, seems I made a mistake and haven't double checked the plural equation after a bug report from a user.

Please discard this patch as the current plural equation is valid. I'm closing this bug as invalid.

Thanks.

comment:4 Changed 4 years ago by claudep

Yes, the current equation is valid. It's just that more and more projects are using another one. Read the rationale here:
https://answers.launchpad.net/launchpad/+question/18324
See also: http://translate.sourceforge.net/wiki/l10n/pluralforms

But as sl coordinator, you are the one to decide :-)

comment:5 Changed 4 years ago by gasperzejn

  • Resolution invalid deleted
  • Status changed from closed to reopened

After a discussion with fellow translators, we've decided we should adopt the new equation.

Can we do this before 1.3 release?

comment:6 Changed 4 years ago by jezdez

  • milestone set to 1.3

Yeah, we can do this, is the attached patch the one to commit?

Changed 4 years ago by claudep

Only plural forms changed

comment:7 Changed 4 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from reopened to new

comment:8 Changed 4 years ago by jezdez

FYI, we can't really fix this bug in Django since Transifex handles plural forms for us. I've filed a bug report there to make sure we don't forget this.

http://trac.transifex.org/ticket/691

Last edited 4 years ago by jezdez (previous) (diff)

comment:9 Changed 4 years ago by jezdez

Okay, the Transifex developers now have tested it on test.transifex.net and ask us if the following plural form example is correct:

# This file is distributed under the same license as the Django package.
# 
msgid ""
msgstr ""
"Project-Id-Version: Django\n"
"Report-Msgid-Bugs-To: http://code.djangoproject.com/\n"
"POT-Creation-Date: 2010-05-13 15:35+0200\n"
"PO-Revision-Date: 2011-02-14 16:14+0000\n"
"Last-Translator: Django team\n"
"Language-Team: English <en@li.org>\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Language: sl\n"
"Plural-Forms: nplurals=4; plural=(n%100==1 ? 1 : n%100==2 ? 2 : n%100==3 || n%100==4 ? 3 : 0)\n"

#: contrib/admin/templates/admin/change_form.html:39
#: contrib/admin/templates/admin/change_list.html:71
#: contrib/admin/templates/admin/auth/user/change_password.html:24
#: contrib/admin/templates/registration/password_change_form.html:15
msgid "Please correct the error below."
msgid_plural "Please correct the errors below."
msgstr[0] "Prosimo, odpravite sledečo napako."
msgstr[1] "Prosimo, odpravite sledeči napaki."
msgstr[2] "Prosimo, odpravite sledeče napake."
msgstr[3] "Prosimo, odpravite sledeče napake."

https://gist.github.com/b8b851f3c4bffa08378f

comment:10 Changed 4 years ago by diegobz@…

  • Cc diegobz@… added

comment:11 Changed 4 years ago by gasperzejn

No, this isn't correct. The plural forms need shuffling around using this pseudocode assignment:

msgstr[0] = msgstr[3]
msgstr[1] = msgstr[0]
msgstr[2] = msgstr[1]
msgstr[3] = msgstr[2]

Thanks.

comment:12 Changed 4 years ago by jezdez

For the record, the Transifex developers are working on an update but can't give a timeline since changing the order of the plural forms isn't supported at the moment. I doubt this will be fixed in time before the final 1.3 release.

Last edited 4 years ago by jezdez (previous) (diff)

comment:13 Changed 4 years ago by patchhammer

  • Easy pickings unset
  • Patch needs improvement set
  • Severity set to Normal
  • Type set to Uncategorized

14129.diff fails to apply cleanly on to trunk

comment:14 Changed 4 years ago by julien

  • Type changed from Uncategorized to Bug

comment:15 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

comment:11 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:12 Changed 2 years ago by aaugustin

The link above now redirects to GitHub issues. It looks like the Transifex devs abandonned their Trac, including the issue we had posted there.

comment:13 Changed 12 months ago by anonymous

  • Summary changed from Fix Slovenian translation plural-forms to Slovenian translation plural-forms

comment:14 Changed 8 months ago by timgraham

  • Component changed from Translations to Internationalization
Note: See TracTickets for help on using tickets.
Back to Top