Catching ImportError in manage.py considered dangerous
|Reported by:||Setok||Owned by:||nobody|
|Severity:||Keywords:||manage settings import sprintnov13|
|Cc:||Łukasz Rekucki, Béres Botond||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The basic implementation of manage.py does little else than check for an ImportError on settings. Unfortunately using try-except to check for module existence in Python is not a very good practise. The problem is that it hides any possible import errors that may occur within settings.py. Sure, the error displayed by manage.py does mention that possibility, but only in parenthesis, after bold text about settings.py missing.
Having just spend several hours trying to figure out what was going on I believe that, in balance, it would be better just to let the Python error fall through and for a proper stacktrace to occur. Alternatively try to figure out a way to detect if it was, in fact, the settings module which was missing, or something else. Annoyingly Python's ImportError does not seem to easily have that information available :(