Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#10370 closed (fixed)

[patch] re-implement MultiValueDict.itervalues() to match values()

Reported by: rfk Owned by: nobody
Component: Core (Other) Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


MultiValueDict modifies values() to yield only the last item from each list, but uses the default itervalues() implementation which yields the entire list. This leads to much confusion since d.values() != list(d.itervalues()).

Attachments (1)

mvd_itervalues.diff (1.2 KB) - added by rfk 7 years ago.
re-implement MultiValueDict.itervalues()

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by rfk

re-implement MultiValueDict.itervalues()

comment:1 Changed 7 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

See also #8447.

comment:2 Changed 7 years ago by russellm

  • Component changed from Uncategorized to Core framework

comment:3 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10241]) Fixed #8847, #10370: added some missing methods to MultiValueDict after [8399]. Thanks, James Turk and rfk.

comment:4 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top