Code

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#8447 closed (fixed)

with change in behavior to MultiValueDict.iteritems, there should be a MultiValueDict.iterlists

Reported by: jamesturk Owned by: jamesturk
Component: Core (Other) Version: master
Severity: Keywords: multivaluedict
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Changeset [8399] changed the value of MultiValueDict's iteritems to return singular items instead of lists (closing #7331) and some people may depend on the ability to iterate over the lists.

There is already a lists() method that is the analog of items(), it seems reasonable that there should be an equivalent iterlists() method that simply does what iteritems() used to do.

related django-developers discussion: http://groups.google.com/group/django-developers/browse_thread/thread/cb99e60e7ed86386

Attachments (2)

iterlists.diff (2.1 KB) - added by jdunck 6 years ago.
addition of iterlists, a test for them matching the iteritems test, and documentation noting they exist
iterlists.2.diff (2.1 KB) - added by jamesturk 6 years ago.
adds small documentation fix to patch

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by jdunck

addition of iterlists, a test for them matching the iteritems test, and documentation noting they exist

comment:1 Changed 6 years ago by jamesturk

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jamesturk
  • Patch needs improvement unset
  • Status changed from new to assigned

first patch has a small error in the documentation

comment:2 Changed 6 years ago by jamesturk

weird.. after trying to update my patch it now says the first patch was submitted by jdunck?

comment:3 Changed 6 years ago by jamesturk

  • Has patch set

Changed 6 years ago by jamesturk

adds small documentation fix to patch

comment:4 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

comment:5 Changed 5 years ago by jacob

  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 5 years ago by jacob

See also #10370.

comment:7 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [10241].

comment:8 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.