Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8447 closed (fixed)

with change in behavior to MultiValueDict.iteritems, there should be a MultiValueDict.iterlists

Reported by: James Turk Owned by: James Turk
Component: Core (Other) Version: master
Severity: Keywords: multivaluedict
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Changeset [8399] changed the value of MultiValueDict's iteritems to return singular items instead of lists (closing #7331) and some people may depend on the ability to iterate over the lists.

There is already a lists() method that is the analog of items(), it seems reasonable that there should be an equivalent iterlists() method that simply does what iteritems() used to do.

related django-developers discussion: http://groups.google.com/group/django-developers/browse_thread/thread/cb99e60e7ed86386

Attachments (2)

iterlists.diff (2.1 KB) - added by Jeremy Dunck 8 years ago.
addition of iterlists, a test for them matching the iteritems test, and documentation noting they exist
iterlists.2.diff (2.1 KB) - added by James Turk 8 years ago.
adds small documentation fix to patch

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Jeremy Dunck

Attachment: iterlists.diff added

addition of iterlists, a test for them matching the iteritems test, and documentation noting they exist

comment:1 Changed 8 years ago by James Turk

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to James Turk
Patch needs improvement: unset
Status: newassigned

first patch has a small error in the documentation

comment:2 Changed 8 years ago by James Turk

weird.. after trying to update my patch it now says the first patch was submitted by jdunck?

comment:3 Changed 8 years ago by James Turk

Has patch: set

Changed 8 years ago by James Turk

Attachment: iterlists.2.diff added

adds small documentation fix to patch

comment:4 Changed 8 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:5 Changed 8 years ago by Jacob

Triage Stage: AcceptedReady for checkin

comment:6 Changed 8 years ago by Jacob

See also #10370.

comment:7 Changed 8 years ago by Jacob

Resolution: fixed
Status: assignedclosed

Fixed in [10241].

comment:8 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top