BooleanField with choices, defaults, and blank=False still given blank option in their formfields

[Nate]

When you give a BooleanField a choice set, a default, and blank=False, the corresponding formfield still offers a blank '---------' option and does not initially set the default value.

[fperetti]

I cant reproduce the bug, someone can do it?

[Nicolás Miyasato]

Hi, I've been working with fperetti and could reproduce part of the issue.
AFAIK the issue should be splitted in two parts:

1. When the blank = True is passed to the models.BooleanField, the generated HTML (using ModelForm) is not consistent with that, as it adds the "------" option.
2. When the default = N is passed to the models.BooleanField, the generated HTML does not have the default = "default"

We could only reproduce the first one using this:

#models.py

from django.db import models

# Create your models here.

CHOICE = [(1,'si'),(2,'no')]
class Ejemplo(models.Model):
       buleanito = models.BooleanField(choices=CHOICE,default=1, blank=False)

# forms.py
from django.forms import ModelForm
from coso.models import Ejemplo

class MiFormulario(ModelForm):
    class Meta:
        model = Ejemplo

./ḿanage shell

from coso.forms import MiFormulario
a = MiFormulario()
print(a)

<tr><th><label for="id_buleanito">Buleanito:</label></th><td><select name="buleanito" id="id_buleanito">

<option value="">---------</option>   # <-------------------------- THIS IS WRONG!!!

<option value="1" selected="selected">si</option>

<option value="2">no</option>

</select></td></tr>

[fperetti]

django/db/models/fields/__init__.py

@@ -371 +371 @@
 
 class BooleanField(Field):
     def __init__(self, *args, **kwargs):
-        kwargs['blank'] = True
+        kwargs['blank'] = False
         if 'default' not in kwargs and not kwargs.get('null'):
             kwargs['default'] = False
         Field.__init__(self, *args, **kwargs)

[Nicolás Miyasato]

So we found that the BooleanField class forces us to have the blank value to True

 Index: django/db/models/fields/_init_.py
===================================================================
--- django/db/models/fields/_init_.py (revisión: 10119)
+++ django/db/models/fields/_init_.py (copia de trabajo)
@@ -371,7 +371,7 @@

class BooleanField(Field):
    def __init__(self, *args, **kwargs):
-        kwargs['blank'] = True  # <------------- This is always set to True!!!
+        kwargs['blank'] = False
        if 'default' not in kwargs and not kwargs.get('null'):
            kwargs['default'] = False
        Field.__init__(self, *args, **kwargs)

As kwargs[blank] is set always to True, it doesn't matter what we pass to the BooleanField.

Does anybody know why this is set always to True?

I can't have a select/combobox with only two options, neither of them being the "--------" one, as it always adds it.

A patch has been submitted, but please tell us why this is hardcoded to the True value.
With this patch, sub-issue *1*

Thanks a lot

[fperetti]

New patch, now must work!

[Ramiro Morales]

See also #10549

[Sebastian Noack]

The blank flag in the BooleanField works in an other way as with most other Fields, since it is passed as required flag to the formfield and the default formfield for BooleanField renders a checkbox, which must be checked when required. I think my patch as submitted by the ticket #10549 would be a better solution.

[Jacob]

(In [10500]) Fixed #9640, #10549: BooleanFields with choices, a default, and null=False now correctly doesn't generate a blank option.

[Jacob]

Milestone 1.1 deleted