BooleanField.formfield() does not handle choices correct. [PATCH]

[sebastian_noack]

If you have a BooleanField, with choices (as in the example below), the formfield() method always returns a TypedChoicesField, with a blank choice at the beginning. This is because of this entry is included always if the blank is True and BooleanFields are always blank=True. So we have to check for null instead of blank, when using BooleanFields, since the blank flag in the BooleanfField does not specify if the field can be empty in forms in contrast to other fields.

FLAG_CHOICES = (
    (0, _('No'),
    (1, _('Yes'),
)

class Foo(models.Model):
    flag = models.BooleanField(choices=FLAG_CHOICES)

[ramiro]

See also #9640

[jacob]

(In [10500]) Fixed #9640, #10549: BooleanFields with choices, a default, and null=False now correctly doesn't generate a blank option.

[SmileyChris]

I must say, it is rather amusing how this tests for something which you can't actually do, due to r10456

[jacob]

Milestone 1.1 deleted