Code

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9634 closed (fixed)

Missing plural string in Slovak translation

Reported by: claude@… Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: mandre, marcel Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The Slovak django.po is missing a Plural string. Even when Django "sub-apps" provide a correct Slovak po file with a Plural string, Django uses the default one (Germanic-based). I suggest to never accept a po file in Django without a Plural string in the header.
The Plural string for Slovak is:
"Plural-Forms: nplurals=3; plural= (n==1) ? 1 : (n>=2 && n<=4) ? 2 : 0;"

Attachments (3)

djangojs.po (3.1 KB) - added by marcel 5 years ago.
Slovak djangojs.po file
django.po (104.5 KB) - added by marcel 5 years ago.
Slovak django.po file
django-sk.diff (55.0 KB) - added by scrool 5 years ago.
Diff of .po files by marcel against files in svn repository. I haven't done any changes. Just a note that it contains much more fixes not only reported bug.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by mtredinnick

  • Cc mandre added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Please create a patch to the django.po file (djangojs.po has no plural forms) to add this change and also update the current plural msgstrs to have the right 'n' values for the translations. The line you're proposing to add makes the existing msgstrs for plural forms incorrect (they current only have 0 and 1), so I don't want to just apply it without fixing those. You don't have to completely update the PO file or anything: just fix the indices on any msgids that have plural forms.

Adding mandre to the CC list, since he did the last Slovak translation and might also be able to help here (Marian, please feel free to remove yourself if you're not interested in following this).

comment:2 Changed 5 years ago by claude@…

I'm completely illiterate in Slovak. It'd be much better if mandre could fix it.

comment:3 Changed 5 years ago by claudep

Moreover the date format strings are wrongly translated:

#: utils/translation/trans_real.py:399
msgid "DATE_FORMAT"
msgstr "DÁTUM_FORMÁT"

#: utils/translation/trans_real.py:400
msgid "DATETIME_FORMAT"
msgstr "DÁTUMAČAS_FORMÁT"

#: utils/translation/trans_real.py:401
msgid "TIME_FORMAT"
msgstr "ČAS_FORMÁT"

#: utils/translation/trans_real.py:417
msgid "YEAR_MONTH_FORMAT"
msgstr "ROK_MESIAC_FORMÁT"

#: utils/translation/trans_real.py:418
msgid "MONTH_DAY_FORMAT"
msgstr "MESIAC_DEŇ_FORMÁT"

This triggers server errors mentionned in ticket:10048

comment:4 Changed 5 years ago by marcel

If there is nobody else who could update the Slovak translation po file to have this bug fixed I could do it (as a native Slovak speaker). Please send me (or point me to) current Slovak po file and I'll try to do my best.

Thanks.

comment:5 Changed 5 years ago by marcel

marcel (at) telka (dot) sk

comment:6 Changed 5 years ago by claudep

The current Slovak po files are available here:
source:django/trunk/django/conf/locale/sk/LC_MESSAGES

Changed 5 years ago by marcel

Slovak djangojs.po file

Changed 5 years ago by marcel

Slovak django.po file

comment:7 follow-up: Changed 5 years ago by marcel

  • Cc marcel added
  • Has patch set

Please integrate attached djangojs.po and django.po files. All known problems are fixed there.

Thanks.

comment:8 in reply to: ↑ 7 Changed 5 years ago by telenieko

  • Triage Stage changed from Unreviewed to Accepted

Replying to marcel:

Please integrate attached djangojs.po and django.po files. All known problems are fixed there.

*Please* as stated in the first comment and in the documentation. Attach a patch (diff) file; It makes things much easier for us. There are lots of ways for doing so. If you are running SVN: "svn diff > mypatch.diff"

Thanks!!

Changed 5 years ago by scrool

Diff of .po files by marcel against files in svn repository. I haven't done any changes. Just a note that it contains much more fixes not only reported bug.

comment:9 Changed 5 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9913]) Fixed #9634 -- Updated Slovak translation. Thanks Marcel Telka and scrool.

comment:10 Changed 5 years ago by mtredinnick

(In [9914]) [1.0.X] Fixed #9634 -- Updated Slovak translation. Thanks Marcel Telka, Marian Andre and scrool.

Backport of r9913 and r9263 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.