Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9278 closed (fixed)

Geographic Admin doesn't show vector overlay when LANGUAGE_BIDI is set

Reported by: jbronn Owned by: jbronn
Component: GIS Version: 1.0
Severity: Keywords: gis rtl
Cc: dane.springmeyer@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

The vector overlay fails to display for when LANGUAGE_BIDI=True -- right-to-left languages like Arabic and Hebrew.

Attachments (3)

geoadmin_bidi_fail.png (39.7 KB) - added by jbronn 8 years ago.
No overlay
geoadmin_rtl_fix.patch (719 bytes) - added by springmeyer 8 years ago.
Patch to force any OpenLayers map to maintain ltr text ordering
geoadmin_rtl_fix_v2.diff (4.6 KB) - added by jbronn 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by jbronn

Attachment: geoadmin_bidi_fail.png added

No overlay

comment:1 Changed 8 years ago by springmeyer

Has patch: set
Needs documentation: unset
Needs tests: set
Patch needs improvement: unset

It appears that when the LANGUAGE_CODE is set to a right-to-left language (noted in http://code.djangoproject.com/browser/django/trunk/django/conf/global_settings.py#L98 LANGUAGES_BIDI]) OpenLayers vectors are not plotted in a visible location. This problem is noted here: http://trac.openlayers.org/ticket/1778 and is prompted by the insertion of the dir="rtl" in the <html> element by the Admin App when a rtl language is requested.

It can be avoided by adding dir="ltr" in the OL map div. The patch attached that does this.

Changed 8 years ago by springmeyer

Attachment: geoadmin_rtl_fix.patch added

Patch to force any OpenLayers map to maintain ltr text ordering

comment:2 Changed 8 years ago by springmeyer

Cc: dane.springmeyer@… added

Changed 8 years ago by jbronn

Attachment: geoadmin_rtl_fix_v2.diff added

comment:3 Changed 8 years ago by jbronn

Resolution: fixed
Status: newclosed

(In [9733]) Fixed #9278, #9694 -- Geographic overlays now display in admin with right to left langauges; simplified transformation process in OpenLayersWidget to fix Ubuntu 8.10/Apache 2.2.9 crash; updated OpenLayers version to 2.7.

comment:4 Changed 8 years ago by jbronn

(In [9734]) [1.0.X] Fixed #9278, #9694 -- Geographic overlays now display in admin with right to left langauges; simplified transformation process in OpenLayersWidget to fix Ubuntu 8.10/Apache 2.2.9 crash; updated OpenLayers version to 2.7.

Backport of r9733 from trunk.

comment:5 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top