#8794 closed (fixed)
Profanity filter suffers from the Scunthorpe problem
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | contrib.comments | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The implementation of the profanity filter suffers from the Scunthorpe Problem; ie. that it considers the town of Scunthorpe, amongst other innocuous words, to be profane.
Profanity filtering is A Hard Problem, and naïve solutions like this one cause frustrating problems to end-users.
Checking the current profanities list for false positives in a couple of word lists I had to hand also yields:
gobbledegook snigger Brushite Cushite Niggerhead Peshito Peshitto Shittah Shittah tree Shittim Shittim wood Shittle Shittlecock Shittleness
Obviously proper names are not in my dictionary, but they cause frequent and often more annoying problems.
I suggest to disable the filter by default so that scope of the problem is limited, and at the very least the filter must be restricted to re.match(r'\b' + word + '\b')
. Users who need stricter profanity filters should have the responsibility for doing so, and potentially annoying their users themselves. Django should not be doing it for them.
Attachments (2)
Change History (9)
comment:1 by , 16 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:2 by , 16 years ago
Triage Stage: | Design decision needed → Accepted |
---|
I have come to believe that we shouldn't be distributing a list of profanities with Django. Problem is, we're committed to backwards compatibility -- so we'll have to leave those in until the next major release.
comment:3 by , 14 years ago
milestone: | → 2.0 |
---|
Check #6290. This ticket has to be pushed for the next major revision ie 2.0.
comment:4 by , 14 years ago
milestone: | 2.0 → 1.3 |
---|
This needs to be handled with our usual deprecation plan rather than just removing it. Bumping to the 1.3 release following a recent discussion on django-dev
comment:5 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
It's quite easy to toggle the COMMENTS_ALLOW_PROFANITIES setting. I am a -0 on this. Am marking this as a DDN.