Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17012 closed Bug (fixed)

Documentation references non-existent hasNoProfanity validator

Reported by: russellm Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by russellm)

The documentation for the PROFANITIES_LIST setting makes a reference to the hasNoProfanities validator.

This validator hasn't existed since Django 0.96, so this reference should be cleaned up.

Credit for the report goes to robinne on the django-users mailing list.

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by russellm

  • Description modified (diff)

comment:2 Changed 3 years ago by aaugustin

  • Resolution set to fixed
  • Status changed from new to closed

In [16935]:

Fixed #17012 - Removed references to the 'hasNoProfanities' validator. Refs #8794.

comment:3 Changed 3 years ago by gremmie

  • Resolution fixed deleted
  • Status changed from closed to reopened

I think there is a typo in the fix [16935]:

It should read "... will be forbidden in comments when COMMENTS_ALLOW_PROFANITIES is False." (not True).

Also, I don't think COMMENTS_ALLOW_PROFANITIES is documented.

comment:4 Changed 3 years ago by aaugustin

Good catch. It's a rather counter intuitive to set something to False to activate a behavior and to True do to nothing :(

And yes, I noticed that COMMENTS_ALLOW_PROFANITIES isn't documented. The "profanities" feature is kept for backwards compatibility but it isn't encouraged (see #8794). I'd rather deprecate it (and its settings) than document it.

comment:5 Changed 3 years ago by aaugustin

In [16936]:

Fixed typo in r16935. Refs #17012.

comment:6 Changed 3 years ago by aaugustin

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.