Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17012 closed Bug (fixed)

Documentation references non-existent hasNoProfanity validator

Reported by: Russell Keith-Magee Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Russell Keith-Magee)

The documentation for the PROFANITIES_LIST setting makes a reference to the hasNoProfanities validator.

This validator hasn't existed since Django 0.96, so this reference should be cleaned up.

Credit for the report goes to robinne on the django-users mailing list.

Change History (6)

comment:1 Changed 5 years ago by Russell Keith-Magee

Description: modified (diff)

comment:2 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed

In [16935]:

Fixed #17012 - Removed references to the 'hasNoProfanities' validator. Refs #8794.

comment:3 Changed 5 years ago by Brian Neal

Resolution: fixed
Status: closedreopened

I think there is a typo in the fix [16935]:

It should read "... will be forbidden in comments when COMMENTS_ALLOW_PROFANITIES is False." (not True).

Also, I don't think COMMENTS_ALLOW_PROFANITIES is documented.

comment:4 Changed 5 years ago by Aymeric Augustin

Good catch. It's a rather counter intuitive to set something to False to activate a behavior and to True do to nothing :(

And yes, I noticed that COMMENTS_ALLOW_PROFANITIES isn't documented. The "profanities" feature is kept for backwards compatibility but it isn't encouraged (see #8794). I'd rather deprecate it (and its settings) than document it.

comment:5 Changed 5 years ago by Aymeric Augustin

In [16936]:

Fixed typo in r16935. Refs #17012.

comment:6 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.
Back to Top