#8731 closed (fixed)
"Days" translation in french could be better
| Reported by: | Sylvain Fankhauser | Owned by: | nobody |
|---|---|---|---|
| Component: | Translations | Version: | dev |
| Severity: | Keywords: | fr, french, days, journées, jours, i18n, locale | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The "days" translation in french is "journées", so when using the timesince tag it gives something like "1 mois, 2 journées", instead of "1 mois, 2 jours".
The attached patch simply replaces the translation "day" => "journée" into "day" => "jour" (same thing for the plural form) for the fr locale.
Attachments (3)
Change History (10)
by , 16 years ago
| Attachment: | django.po.diff added |
|---|
comment:1 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 by , 16 years ago
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
Yes, as you say "1 mois, 2 jours" is what should be displayed, but currently it is "1 mois, 2 journées" which is displayed when using timesince (look at the django.po file, the "days" key, it is translated to "journées").
So my patch was correcting this translation by translating "days" into "jours" instead of "journées", which, I think, is "mainstream" french.
comment:3 by , 16 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
Whoops, my bad, I had misread your original description. I confirm that your patch is right. Thanks!
comment:4 by , 16 years ago
| milestone: | → 1.0 |
|---|
Argh... I first posted the wrong patch ("8759.typo.diff"), please disregard that one and consider "8731.typo.diff" instead. My brain is definitely failing these days.
Sephi, I've reposted your patch because it didn't apply properly. So I posted the same as yours, but which applies nicely to r8783.
Also bumping to 1.0, if there's a bit of time left before release to check it in. It's a trivial change but that fixes a quite silly and annoying bug in the French locale. Thanks again Sephi for the report and fix.
by , 16 years ago
| Attachment: | 8731.typo.diff added |
|---|
Same patch as Sephi's, but applies to r8783 >>> Consider this one, not "8759.typo.diff" <<<
comment:5 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
The current translation is perfectly valid and "1 mois, 2 jours" is what should be displayed.
"journée" only refers to daylight time (say roughly from 6am to 6pm), while "jour", in this context, refers to the full 24 hours.
At least, I'm speaking for "mainstream" French. If you think this is incorrect in another dialect (e.g. Quebecois) please post your patch to the respective locale.