Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8206 closed (fixed)

Remove models.base.Model.validate(), manipulator field functions, validator lists

Reported by: mtredinnick Owned by: gwilson
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

With the model-aware validation being pushed to after 1.0, we should ensure nobody uses code that is intentionally in a broken or unsupported state. This means

  • Removing django.db.models.base.Model.validate(), since it's always been incomplete and not to be used. But still people try using it. It's not part of the public API at the moment.
  • Removing code in django.db.models.fields that is only to support manipulators. They are only oldforms-admin related.
  • Removing validator lists from field classes, since they're again only oldforms-admin related.

This probably goes after removing oldforms (#7742) to get the ordering right for people still using oldforms + manipulators.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by gwilson

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to gwilson
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 in reply to: ↑ description Changed 6 years ago by gwilson

Replying to mtredinnick:

  • Removing code in django.db.models.fields that is only to support manipulators. They are only oldforms-admin related.
  • Removing validator lists from field classes, since they're again only oldforms-admin related.

I'm rolling both of these into #7742, as they are oldforms-related but will need to stick around until the rest of Django is oldforms-free.

comment:3 Changed 6 years ago by gwilson

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8348]) Fixed #8206 -- Removed validate methods of Model and Model fields. They are are unsupported for 1.0 and will be replaced with more complete model validation (refs #6845).

comment:4 Changed 3 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.