Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#8191 closed (fixed)

Queryset improvements for extra() calls

Reported by: Malcolm Tredinnick Owned by: Malcolm Tredinnick
Component: Database layer (models, ORM) Version: dev
Severity: Keywords:
Cc: Matthijs Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There are a few related problems in calling the extra() on querysets related to it handles parameters for the extra_select parameter. Currently they

  • don't merge correctly
  • aren't removed correctly
  • don't handle updates correctly.

All of these involve the same dozen lines of code, so I'm making this the tracking ticket for the three problems.

I'm working on patch that incorporates mullendr's diagnoses and ideas from #7957 and #7961. It doesn't quite work to address them individually at the moment.

Change History (6)

comment:1 by Malcolm Tredinnick, 16 years ago

Cc: Matthijs added
milestone: → 1.0
Triage Stage: Unreviewed → Accepted

comment:2 by Jacob, 16 years ago

#8039 was a duplicate, and has a test case for one of these problems.

comment:3 by Malcolm Tredinnick, 16 years ago

#8039 doesn't look like an exact dupe, but I'll address it at the same time. It's probably in the same area.

comment:4 by Malcolm Tredinnick, 16 years ago

#8063 is related, too.

comment:5 by Malcolm Tredinnick, 16 years ago

Resolution: → fixed
Status: new → closed

(In [8426]) Changed the (internal) way extra(select=.., select_params=...) handling is done
so that parameters stay with their select items. This means that merging and
trimming of those items is handled correctly.

Refs #7957, #7961. Fixed #8191.

comment:6 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top