Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8191 closed (fixed)

Queryset improvements for extra() calls

Reported by: mtredinnick Owned by: mtredinnick
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: mullendr Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There are a few related problems in calling the extra() on querysets related to it handles parameters for the extra_select parameter. Currently they

  • don't merge correctly
  • aren't removed correctly
  • don't handle updates correctly.

All of these involve the same dozen lines of code, so I'm making this the tracking ticket for the three problems.

I'm working on patch that incorporates mullendr's diagnoses and ideas from #7957 and #7961. It doesn't quite work to address them individually at the moment.

Change History (6)

comment:1 Changed 7 years ago by mtredinnick

  • Cc mullendr added
  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by jacob

#8039 was a duplicate, and has a test case for one of these problems.

comment:3 Changed 7 years ago by mtredinnick

#8039 doesn't look like an exact dupe, but I'll address it at the same time. It's probably in the same area.

comment:4 Changed 7 years ago by mtredinnick

#8063 is related, too.

comment:5 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8426]) Changed the (internal) way extra(select=.., select_params=...) handling is done
so that parameters stay with their select items. This means that merging and
trimming of those items is handled correctly.

Refs #7957, #7961. Fixed #8191.

comment:6 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top