Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8191 closed (fixed)

Queryset improvements for extra() calls

Reported by: Malcolm Tredinnick Owned by: Malcolm Tredinnick
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Matthijs Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


There are a few related problems in calling the extra() on querysets related to it handles parameters for the extra_select parameter. Currently they

  • don't merge correctly
  • aren't removed correctly
  • don't handle updates correctly.

All of these involve the same dozen lines of code, so I'm making this the tracking ticket for the three problems.

I'm working on patch that incorporates mullendr's diagnoses and ideas from #7957 and #7961. It doesn't quite work to address them individually at the moment.

Change History (6)

comment:1 Changed 8 years ago by Malcolm Tredinnick

Cc: Matthijs added
milestone: 1.0
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Jacob

#8039 was a duplicate, and has a test case for one of these problems.

comment:3 Changed 8 years ago by Malcolm Tredinnick

#8039 doesn't look like an exact dupe, but I'll address it at the same time. It's probably in the same area.

comment:4 Changed 8 years ago by Malcolm Tredinnick

#8063 is related, too.

comment:5 Changed 8 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [8426]) Changed the (internal) way extra(select=.., select_params=...) handling is done
so that parameters stay with their select items. This means that merging and
trimming of those items is handled correctly.

Refs #7957, #7961. Fixed #8191.

comment:6 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top