Chaining Queryset.extra() methods that contain parameters breaks the query

[Matthijs]

To reproduce:

Precondition a user 'root' exists with id=1

from django.contrib.auth.models import User
for result in User.objects.extra(select=
        {'foo3': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.username = %s)"}
        , select_params=['root']).extra(select=
        {'foo2': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.id = %s)"}
        , select_params=['1']):
    print result.foo3
# output should be:
# 1
# 1
for result in User.objects.extra(select=
        {'foo1': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.username = %s)"}
        , select_params=['root']).extra(select=
        {'foo2': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.id = %s)"}
        , select_params=['1']):
    print result.foo1
# output should be:
# 1
# 1

[Matthijs]

patch to fix extra().extra() problem

[Matthijs]

file that demonstrated bug

[Malcolm Tredinnick]

The patch looks like it's along the right lines, although I don't really like adding an append() method to the sorted dictionary. That's a bit of API creep that we can probably avoid.

Fixed milestone and description.

[Matthijs]

Replying to mtredinnick:

The patch looks like it's along the right lines, although I don't really like adding an append() method to the sorted dictionary. That's a bit of API creep that we can probably avoid.

I see the SortedDict more as a list with an additional dict interface. But I am curious how you would solve it.

Also if you are going to work on this ticket you might want to check out ticket #7961 as well since it reports and solves an additional bug in this area of the code.

[Malcolm Tredinnick]

Closing as a dupe of #8191, which is for the broader problem. This ticket is a symptom of the larger problem with extra's parameter handling. Fix isn't hard, but I can't do it in isolation from #7961.

[Malcolm Tredinnick]

(In [8426]) Changed the (internal) way extra(select=.., select_params=...) handling is done
so that parameters stay with their select items. This means that merging and
trimming of those items is handled correctly.

Refs #7957, #7961. Fixed #8191.

[Jacob]

Milestone 1.0 deleted