Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8040 closed (fixed)

SlugField format not enforced

Reported by: Daniel Pope <dan@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords: aug22sprint
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

models.SlugField is documented as "a short label for something, containing only letters, numbers, underscores or hyphens."

However, with forms.ModelForm and newforms-admin, this formatting is not enforced. The ModelForms documentation instead states that models.SlugField is represented by a forms.CharField (ie. validation occurs).

models.SlugField.formfield() should return a forms.RegexField suitable for validating the field as a slug (and the ModelForms documentation should reflect this).

Attachments (2)

8040-slug-validation.diff (2.3 KB) - added by Daniel Pope <dan@…> 6 years ago.
8040.patch (2.3 KB) - added by cgrady 6 years ago.
updated patch (minor position change in fields/init.py)

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by Daniel Pope <dan@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Should read:

...(ie. no validation occurs)

;)

comment:2 Changed 6 years ago by Jökull Sólberg Auðunsson <jokullsolberg@…>

Possibly related to model level validation propagation (a spoonful of sugar with that?)

#6845

comment:3 Changed 6 years ago by jacob

  • milestone set to 1.0
  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by Daniel Pope <dan@…>

comment:4 Changed 6 years ago by Daniel Pope <dan@…>

  • Has patch set

I implemented that validation using a RegexField, but all the other models fields that need syntax validation define their own forms.Field subclass. I was reluctant to go ahead and add that at this point.

Changed 6 years ago by cgrady

updated patch (minor position change in fields/init.py)

comment:5 Changed 6 years ago by cgrady

  • Keywords aug22sprint added

test properly fails before applying fix, passes after, validation then works correctly after patch is applied - looks good to me :)

comment:6 Changed 6 years ago by brosner

  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [8477]) Fixed #8040 -- SlugField now returns a proper formfield to deal with validation. Thanks Daniel Pope for the ticket and patch.

comment:8 Changed 6 years ago by gwilson

(In [8616]) Removed oldforms, validators, and related code:

  • Removed Manipulator, AutomaticManipulator, and related classes.
  • Removed oldforms specific bits from model fields:
    • Removed validator_list and core arguments from constructors.
    • Removed the methods:
      • get_manipulator_field_names
      • get_manipulator_field_objs
      • get_manipulator_fields
      • get_manipulator_new_data
      • prepare_field_objs_and_params
      • get_follow
    • Renamed flatten_data method to value_to_string for better alignment with its use by the serialization framework, which was the only remaining code using flatten_data.
  • Removed oldforms methods from django.db.models.Options class: get_followed_related_objects, get_data_holders, get_follow, and has_field_type.
  • Removed oldforms-admin specific options from django.db.models.fields.related classes: num_in_admin, min_num_in_admin, max_num_in_admin, num_extra_on_change, and edit_inline.
  • Serialization framework
    • Serializer.get_string_value now calls the model fields' renamed value_to_string methods.
    • Removed a special-casing of models.DateTimeField in core.serializers.base.Serializer.get_string_value that's handled by django.db.models.fields.DateTimeField.value_to_string.
  • Removed django.core.validators:
    • Moved ValidationError exception to django.core.exceptions.
    • For the couple places that were using validators, brought over the necessary code to maintain the same functionality.
  • Introduced a SlugField form field for validation and to compliment the SlugField model field (refs #8040).
  • Removed an oldforms-style model creation hack (refs #2160).

comment:15 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.