SlugField format not enforced

[Daniel Pope <dan@…>]

models.SlugField is documented as "a short label for something, containing only letters, numbers, underscores or hyphens."

However, with forms.ModelForm and newforms-admin, this formatting is not enforced. The ModelForms documentation instead states that models.SlugField is represented by a forms.CharField (ie. validation occurs).

models.SlugField.formfield() should return a forms.RegexField suitable for validating the field as a slug (and the ModelForms documentation should reflect this).

[Daniel Pope <dan@…>]

Should read:

...(ie. no validation occurs)

;)

[Jökull Sólberg Auðunsson <jokullsolberg@…>]

Possibly related to model level validation propagation (a spoonful of sugar with that?)

#6845

[Daniel Pope <dan@…>]

I implemented that validation using a RegexField, but all the other models fields that need syntax validation define their own forms.Field subclass. I was reluctant to go ahead and add that at this point.

[Collin Grady]

updated patch (minor position change in fields/init.py)

[Collin Grady]

test properly fails before applying fix, passes after, validation then works correctly after patch is applied - looks good to me :)

[Brian Rosner]

(In [8477]) Fixed #8040 -- SlugField now returns a proper formfield to deal with validation. Thanks Daniel Pope for the ticket and patch.

[Gary Wilson]

(In [8616]) Removed oldforms, validators, and related code:

• Removed Manipulator, AutomaticManipulator, and related classes.
• Removed oldforms specific bits from model fields:
  • Removed validator_list and core arguments from constructors.
  • Removed the methods:
    • get_manipulator_field_names
    • get_manipulator_field_objs
    • get_manipulator_fields
    • get_manipulator_new_data
    • prepare_field_objs_and_params
    • get_follow
  • Renamed flatten_data method to value_to_string for better alignment with its use by the serialization framework, which was the only remaining code using flatten_data.
• Removed oldforms methods from django.db.models.Options class: get_followed_related_objects, get_data_holders, get_follow, and has_field_type.
• Removed oldforms-admin specific options from django.db.models.fields.related classes: num_in_admin, min_num_in_admin, max_num_in_admin, num_extra_on_change, and edit_inline.
• Serialization framework
  • Serializer.get_string_value now calls the model fields' renamed value_to_string methods.
  • Removed a special-casing of models.DateTimeField in core.serializers.base.Serializer.get_string_value that's handled by django.db.models.fields.DateTimeField.value_to_string.
• Removed django.core.validators:
  • Moved ValidationError exception to django.core.exceptions.
  • For the couple places that were using validators, brought over the necessary code to maintain the same functionality.
• Introduced a SlugField form field for validation and to compliment the SlugField model field (refs #8040).
• Removed an oldforms-style model creation hack (refs #2160).

[Jacob]

Milestone 1.0 deleted