Opened 16 years ago
Closed 12 years ago
#7733 closed Cleanup/optimization (wontfix)
Make clickable area of object links larger
Reported by: | Michael Newman | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | nfa-someday |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description
Per a django-dev discussion, The objects in admin should provide more room for users to click on. This patch changes the link's anchor tag to display black with will fill the whole cell.
Attachments (7)
Change History (20)
by , 16 years ago
Attachment: | 7733-larger-admin-clickable-area.diff added |
---|
by , 16 years ago
Attachment: | 7733.patch added |
---|
comment:1 by , 16 years ago
Added a slightly different implementation: the clickable area now fills the vertical area, for single line rows and links within the table body are not changed, and still operate as normal html links (e.g. fields that generate html tags).
comment:2 by , 16 years ago
Triage Stage: | Unreviewed → Accepted |
---|
by , 16 years ago
Attachment: | 7733-list_display_links.patch added |
---|
Includes fix for all 'list_display_links' fields, excluding 'allow_tags' fields
comment:3 by , 16 years ago
Ok, here's what I understand needs to be done:
- standard edit links and field listed in
list_display_links
made bigger (fill the whole cell) - any other links (e.g. using
allow_tags
on a field) should not be affected - The dashboard should also function with the bigger links
I've added another patch that implements these changes, because fields added in list_display_links
are not inside a <th>
field. A class had to be added to the HTML to distinguish links added automatically through list_display_links
from those done through allow_tags
. The "edit" and "delete" links on the dashboard have not been changed.
Should the status be changed from Accepted back to Unreviewed?
by , 16 years ago
Attachment: | 7733-list_display_links.diff added |
---|
Online patch preview problems, removed an EOL difference
comment:4 by , 16 years ago
I respectfully disagree with Will on the execution of this idea. 99 percent of the time the user is wanting to hit that big, bold link on the left. Other links rendered by the use of the list_display_links
option have always been visually treated as secondary (11px normal type instead of the 12px bold used for the usual link). Changing that treatment is not productive because too much of the page could become big and bold.
Further, the clickable area of those secondary links should not be enlarged because their behavior would then be inconsistent with their visual treatment. Thus my patch makes the clickable area of big & bold links bigger and leaves all else alone.
by , 16 years ago
Attachment: | clikable-area.diff added |
---|
Only enlarge clickable area of links in th elements
comment:5 by , 16 years ago
Version: | newforms-admin → SVN |
---|
by , 16 years ago
Attachment: | clickable-area.diff added |
---|
Fixed ill effect on object history tables and accounted for admindoc model list.
comment:7 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → Cleanup/optimization |
comment:8 by , 14 years ago
Component: | contrib.admin → User Experience |
---|---|
Easy pickings: | unset |
Triage Stage: | Accepted → Design decision needed |
This is essentially a UX question so I'm flicking the component field for this ticket to appear on the UX people's radars. At this stage we need at least a final design decision for the approach to follow.
comment:9 by , 13 years ago
UI/UX: | set |
---|
comment:10 by , 13 years ago
Component: | User Experience → contrib.admin |
---|
comment:11 by , 13 years ago
Julian: Alex and I are happy to let you make the decision, so go for it!
by , 13 years ago
Attachment: | 7733.larger-changelist-clickable-area.diff added |
---|
comment:12 by , 13 years ago
I have updated benspaulding's patch to current trunk. It doesn't mean that I'm endorsing it. In fact, I'm struggling to see how useful all this really is. I'm going to take this to django-ux (will post link here when that's done).
comment:13 by , 12 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Closing as per Julien's last comment.
Introducing large clickable areas in the admin site