Code

Opened 6 years ago

Closed 13 months ago

#7733 closed Cleanup/optimization (wontfix)

Make clickable area of object links larger

Reported by: Mnewman Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: nfa-someday
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Per a django-dev discussion, The objects in admin should provide more room for users to click on. This patch changes the link's anchor tag to display black with will fill the whole cell.

Attachments (7)

7733-larger-admin-clickable-area.diff (618 bytes) - added by Mnewman 6 years ago.
7733.patch (519 bytes) - added by Will Hardy 6 years ago.
Introducing large clickable areas in the admin site
7733-list_display_links.patch (2.1 KB) - added by willhardy 6 years ago.
Includes fix for all 'list_display_links' fields, excluding 'allow_tags' fields
7733-list_display_links.diff (2.0 KB) - added by willhardy 6 years ago.
Online patch preview problems, removed an EOL difference
clikable-area.diff (2.3 KB) - added by benspaulding 6 years ago.
Only enlarge clickable area of links in th elements
clickable-area.diff (2.9 KB) - added by benspaulding 6 years ago.
Fixed ill effect on object history tables and accounted for admindoc model list.
7733.larger-changelist-clickable-area.diff (1.2 KB) - added by julien 3 years ago.

Download all attachments as: .zip

Change History (20)

Changed 6 years ago by Mnewman

Changed 6 years ago by Will Hardy

Introducing large clickable areas in the admin site

comment:1 Changed 6 years ago by Will Hardy

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Added a slightly different implementation: the clickable area now fills the vertical area, for single line rows and links within the table body are not changed, and still operate as normal html links (e.g. fields that generate html tags).

comment:2 Changed 6 years ago by serialx

  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by willhardy

Includes fix for all 'list_display_links' fields, excluding 'allow_tags' fields

comment:3 Changed 6 years ago by willhardy

Ok, here's what I understand needs to be done:

  • standard edit links and field listed in list_display_links made bigger (fill the whole cell)
  • any other links (e.g. using allow_tags on a field) should not be affected
  • The dashboard should also function with the bigger links

I've added another patch that implements these changes, because fields added in list_display_links are not inside a <th> field. A class had to be added to the HTML to distinguish links added automatically through list_display_links from those done through allow_tags. The "edit" and "delete" links on the dashboard have not been changed.

Should the status be changed from Accepted back to Unreviewed?

Changed 6 years ago by willhardy

Online patch preview problems, removed an EOL difference

comment:4 Changed 6 years ago by benspaulding

I respectfully disagree with Will on the execution of this idea. 99 percent of the time the user is wanting to hit that big, bold link on the left. Other links rendered by the use of the list_display_links option have always been visually treated as secondary (11px normal type instead of the 12px bold used for the usual link). Changing that treatment is not productive because too much of the page could become big and bold.

Further, the clickable area of those secondary links should not be enlarged because their behavior would then be inconsistent with their visual treatment. Thus my patch makes the clickable area of big & bold links bigger and leaves all else alone.

Changed 6 years ago by benspaulding

Only enlarge clickable area of links in th elements

comment:5 Changed 6 years ago by Alex

  • Version changed from newforms-admin to SVN

Changed 6 years ago by benspaulding

Fixed ill effect on object history tables and accounted for admindoc model list.

comment:6 Changed 5 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:7 Changed 3 years ago by baumer1122

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:8 Changed 3 years ago by julien

  • Component changed from contrib.admin to User Experience
  • Easy pickings unset
  • Triage Stage changed from Accepted to Design decision needed

This is essentially a UX question so I'm flicking the component field for this ticket to appear on the UX people's radars. At this stage we need at least a final design decision for the approach to follow.

comment:9 Changed 3 years ago by julien

  • UI/UX set

comment:10 Changed 3 years ago by julien

  • Component changed from User Experience to contrib.admin

comment:11 Changed 3 years ago by jacob

Julian: Alex and I are happy to let you make the decision, so go for it!

Changed 3 years ago by julien

comment:12 Changed 3 years ago by julien

I have updated benspaulding's patch to current trunk. It doesn't mean that I'm endorsing it. In fact, I'm struggling to see how useful all this really is. I'm going to take this to django-ux (will post link here when that's done).

comment:13 Changed 13 months ago by apollo13

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as per Julien's last comment.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.