Opened 8 years ago

Closed 4 years ago

#7733 closed Cleanup/optimization (wontfix)

Make clickable area of object links larger

Reported by: Michael Newman Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: nfa-someday
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Per a django-dev discussion, The objects in admin should provide more room for users to click on. This patch changes the link's anchor tag to display black with will fill the whole cell.

Attachments (7)

7733-larger-admin-clickable-area.diff (618 bytes) - added by Michael Newman 8 years ago.
7733.patch (519 bytes) - added by Will Hardy 8 years ago.
Introducing large clickable areas in the admin site
7733-list_display_links.patch (2.1 KB) - added by Will Hardy 8 years ago.
Includes fix for all 'list_display_links' fields, excluding 'allow_tags' fields
7733-list_display_links.diff (2.0 KB) - added by Will Hardy 8 years ago.
Online patch preview problems, removed an EOL difference
clikable-area.diff (2.3 KB) - added by Ben Spaulding 8 years ago.
Only enlarge clickable area of links in th elements
clickable-area.diff (2.9 KB) - added by Ben Spaulding 8 years ago.
Fixed ill effect on object history tables and accounted for admindoc model list.
7733.larger-changelist-clickable-area.diff (1.2 KB) - added by Julien Phalip 5 years ago.

Download all attachments as: .zip

Change History (20)

Changed 8 years ago by Michael Newman

Changed 8 years ago by Will Hardy

Attachment: 7733.patch added

Introducing large clickable areas in the admin site

comment:1 Changed 8 years ago by Will Hardy

Added a slightly different implementation: the clickable area now fills the vertical area, for single line rows and links within the table body are not changed, and still operate as normal html links (e.g. fields that generate html tags).

comment:2 Changed 8 years ago by Sung-jin Hong

Triage Stage: UnreviewedAccepted

Changed 8 years ago by Will Hardy

Includes fix for all 'list_display_links' fields, excluding 'allow_tags' fields

comment:3 Changed 8 years ago by Will Hardy

Ok, here's what I understand needs to be done:

  • standard edit links and field listed in list_display_links made bigger (fill the whole cell)
  • any other links (e.g. using allow_tags on a field) should not be affected
  • The dashboard should also function with the bigger links

I've added another patch that implements these changes, because fields added in list_display_links are not inside a <th> field. A class had to be added to the HTML to distinguish links added automatically through list_display_links from those done through allow_tags. The "edit" and "delete" links on the dashboard have not been changed.

Should the status be changed from Accepted back to Unreviewed?

Changed 8 years ago by Will Hardy

Online patch preview problems, removed an EOL difference

comment:4 Changed 8 years ago by Ben Spaulding

I respectfully disagree with Will on the execution of this idea. 99 percent of the time the user is wanting to hit that big, bold link on the left. Other links rendered by the use of the list_display_links option have always been visually treated as secondary (11px normal type instead of the 12px bold used for the usual link). Changing that treatment is not productive because too much of the page could become big and bold.

Further, the clickable area of those secondary links should not be enlarged because their behavior would then be inconsistent with their visual treatment. Thus my patch makes the clickable area of big & bold links bigger and leaves all else alone.

Changed 8 years ago by Ben Spaulding

Attachment: clikable-area.diff added

Only enlarge clickable area of links in th elements

comment:5 Changed 8 years ago by Alex Gaynor

Version: newforms-adminSVN

Changed 8 years ago by Ben Spaulding

Attachment: clickable-area.diff added

Fixed ill effect on object history tables and accounted for admindoc model list.

comment:6 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:7 Changed 6 years ago by Peter Baumgartner

Severity: Normal
Type: Cleanup/optimization

comment:8 Changed 6 years ago by Julien Phalip

Component: contrib.adminUser Experience
Easy pickings: unset
Triage Stage: AcceptedDesign decision needed

This is essentially a UX question so I'm flicking the component field for this ticket to appear on the UX people's radars. At this stage we need at least a final design decision for the approach to follow.

comment:9 Changed 6 years ago by Julien Phalip

UI/UX: set

comment:10 Changed 6 years ago by Julien Phalip

Component: User Experiencecontrib.admin

comment:11 Changed 5 years ago by Jacob

Julian: Alex and I are happy to let you make the decision, so go for it!

Changed 5 years ago by Julien Phalip

comment:12 Changed 5 years ago by Julien Phalip

I have updated benspaulding's patch to current trunk. It doesn't mean that I'm endorsing it. In fact, I'm struggling to see how useful all this really is. I'm going to take this to django-ux (will post link here when that's done).

comment:13 Changed 4 years ago by Florian Apolloner

Resolution: wontfix
Status: newclosed

Closing as per Julien's last comment.

Note: See TracTickets for help on using tickets.
Back to Top