Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#7141 closed (fixed)

Estonian translation missing in global_settings.py

Reported by: mrts Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (7)

et.diff (112.9 KB) - added by mrts 6 years ago.
Patch against [7510]
et.alt.diff (166.8 KB) - added by RaceCondition 6 years ago.
alternative estonian translations
et.alt.2.diff (107.5 KB) - added by RaceCondition 6 years ago.
et.2.diff (113.2 KB) - added by RaceCondition <eallik@…> 6 years ago.
settings.diff (512 bytes) - added by telenieko 6 years ago.
Pending changes to global_settings.py
et.3.diff (113.2 KB) - added by RaceCondition <eallik@…> 6 years ago.
Same as before with minor fixes and enhancements
et.4.diff (3.3 KB) - added by RaceCondition <eallik@…> 6 years ago.

Download all attachments as: .zip

Change History (28)

Changed 6 years ago by mrts

Patch against [7510]

comment:1 follow-up: Changed 6 years ago by RaceCondition

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.

Changed 6 years ago by RaceCondition

alternative estonian translations

comment:2 in reply to: ↑ 1 Changed 6 years ago by telenieko

  • Triage Stage changed from Unreviewed to Accepted

Replying to RaceCondition:

I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.

What is alternative in the alternative patch? Or does it mean "improved"? (not everybody speaks Estonian) Knowing the difference between both diff will make things easier for mtredinnick when he comes back.

comment:3 Changed 6 years ago by telenieko

Three points for me for asking something answered on the quoted text of my reply... Forget my question!!!

Changed 6 years ago by RaceCondition

comment:4 Changed 6 years ago by anonymous

The previous et.alt.diff file did not conform to the standard i18n diff file, so I've fixed it. Still haven't merged some translations that my diff is missing from the diff that mrts attached.

comment:5 follow-up: Changed 6 years ago by mrts

  • Patch needs improvement set

It should be decided who will maintain the Estonian translation. I'm willing to do it, but I am also happy to delegate maintenance to RaceCondition. What matters is a long-term commitment to improving the translation. I'm sure that I use and contribute to Django on regular basis in the foreseeable future, but it's up to RaceCondition to decide if we prefers to maintain it.

The maintainer should

  • be accepted by Django i18n team (Malcolm?)
  • do the discussed review and upload a final complete patch
  • mark this ticket as ready for checkin and/or commit it to et tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).

comment:6 Changed 6 years ago by mrts

doh, s/we/he

comment:7 in reply to: ↑ 5 Changed 6 years ago by telenieko

Replying to mrts:

  • be accepted by Django i18n team (Malcolm?)

Not really a requirement, you just have to take care of your .po file and try to keep it up-to-date.

  • mark this ticket as ready for checkin and/or commit it to et tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).

Not exactly, translators which over time proved a willingness to maintain their languages and always were uploading clean and nice patches were gifted with commit rights on their locale's. But most of the languages still go trhought tickets, well event Catalan and Spanish still open tickets before been commited :)

comment:8 follow-up: Changed 6 years ago by Uninen

Responding to Marc Fargas' call for translation reviews.

I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations. (Although first one has some problems in the beginning of the file -- don't know if that affects to merging.)

I'm not native speaker of Estonian so I cannot comment on details, but bot of there are legit translations.

comment:9 in reply to: ↑ 8 Changed 6 years ago by telenieko

Replying to Uninen:

I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations.

Thanks a lot for the help!

Hope RaceCondition can attach a single diff with all toghether (his last comment says he still misses a few strings from the first patch).
Also, RaceCondition, will you want to keep Estonian up-to-date?
Thanks

comment:10 Changed 6 years ago by mrts

RaceCondition is just now preparing a final translation that merges both translation files.

He will mark this ticket as ready for checkin when the translation is done. Before that neither of the translations should be merged.

I vote for RaceCondition to become the official Estonian translation maintainer.

Changed 6 years ago by RaceCondition <eallik@…>

comment:11 Changed 6 years ago by RaceCondition

Merged diffs from myself and mrts, also fixed a few typos found during review.

comment:12 Changed 6 years ago by telenieko

(In [7668]) Refs #7141, New Estonian translation. (Thanks Erik Allik & mrts)

comment:13 Changed 6 years ago by telenieko

  • Triage Stage changed from Accepted to Ready for checkin

Done, but I can't commit global_settings.py let's hope somebody who can can put the change.

Changed 6 years ago by telenieko

Pending changes to global_settings.py

Changed 6 years ago by RaceCondition <eallik@…>

Same as before with minor fixes and enhancements

comment:14 Changed 6 years ago by RaceCondition

I don't know why telenieko attached settings.diff with changes to global_settings.py because my patch already contains the same diff.

comment:15 Changed 6 years ago by RaceCondition

Nevermind that settings.diff question.

Changed 6 years ago by RaceCondition <eallik@…>

comment:16 Changed 6 years ago by RaceCondition

  • Patch needs improvement unset

comment:17 Changed 6 years ago by telenieko

(In [7672]) Refs #7141, Estonian updates (Thanks Erik Allik)

comment:18 Changed 6 years ago by telenieko

  • milestone set to 1.0
  • Summary changed from Estonian translation to Estonian translation missing in global_settings.py

comment:19 Changed 6 years ago by jacob

(In [7697]) Added Estonian to global_settings.LANGUAGES. Refs #7141.

comment:20 Changed 6 years ago by telenieko

  • Resolution set to fixed
  • Status changed from new to closed

Thanks jacob! Closing now then.

comment:21 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.