Opened 17 years ago

Closed 17 years ago

Last modified 13 years ago

#7141 closed (fixed)

Estonian translation missing in global_settings.py

Reported by: mrts Owned by: nobody
Component: Translations Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Attachments (7)

et.diff (112.9 KB ) - added by mrts 17 years ago.
Patch against [7510]
et.alt.diff (166.8 KB ) - added by Erik Allik 17 years ago.
alternative estonian translations
et.alt.2.diff (107.5 KB ) - added by Erik Allik 17 years ago.
et.2.diff (113.2 KB ) - added by RaceCondition <eallik@…> 17 years ago.
settings.diff (512 bytes ) - added by Marc Fargas 17 years ago.
Pending changes to global_settings.py
et.3.diff (113.2 KB ) - added by RaceCondition <eallik@…> 17 years ago.
Same as before with minor fixes and enhancements
et.4.diff (3.3 KB ) - added by RaceCondition <eallik@…> 17 years ago.

Download all attachments as: .zip

Change History (28)

by mrts, 17 years ago

Attachment: et.diff added

Patch against [7510]

comment:1 by Erik Allik, 17 years ago

I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.

by Erik Allik, 17 years ago

Attachment: et.alt.diff added

alternative estonian translations

in reply to:  1 comment:2 by Marc Fargas, 17 years ago

Triage Stage: UnreviewedAccepted

Replying to RaceCondition:

I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.

What is alternative in the alternative patch? Or does it mean "improved"? (not everybody speaks Estonian) Knowing the difference between both diff will make things easier for mtredinnick when he comes back.

comment:3 by Marc Fargas, 17 years ago

Three points for me for asking something answered on the quoted text of my reply... Forget my question!!!

by Erik Allik, 17 years ago

Attachment: et.alt.2.diff added

comment:4 by anonymous, 17 years ago

The previous et.alt.diff file did not conform to the standard i18n diff file, so I've fixed it. Still haven't merged some translations that my diff is missing from the diff that mrts attached.

comment:5 by mrts, 17 years ago

Patch needs improvement: set

It should be decided who will maintain the Estonian translation. I'm willing to do it, but I am also happy to delegate maintenance to RaceCondition. What matters is a long-term commitment to improving the translation. I'm sure that I use and contribute to Django on regular basis in the foreseeable future, but it's up to RaceCondition to decide if we prefers to maintain it.

The maintainer should

  • be accepted by Django i18n team (Malcolm?)
  • do the discussed review and upload a final complete patch
  • mark this ticket as ready for checkin and/or commit it to et tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).

comment:6 by mrts, 17 years ago

doh, s/we/he

in reply to:  5 comment:7 by Marc Fargas, 17 years ago

Replying to mrts:

  • be accepted by Django i18n team (Malcolm?)

Not really a requirement, you just have to take care of your .po file and try to keep it up-to-date.

  • mark this ticket as ready for checkin and/or commit it to et tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).

Not exactly, translators which over time proved a willingness to maintain their languages and always were uploading clean and nice patches were gifted with commit rights on their locale's. But most of the languages still go trhought tickets, well event Catalan and Spanish still open tickets before been commited :)

comment:8 by Ville Säävuori, 17 years ago

Responding to Marc Fargas' call for translation reviews.

I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations. (Although first one has some problems in the beginning of the file -- don't know if that affects to merging.)

I'm not native speaker of Estonian so I cannot comment on details, but bot of there are legit translations.

in reply to:  8 comment:9 by Marc Fargas, 17 years ago

Replying to Uninen:

I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations.

Thanks a lot for the help!

Hope RaceCondition can attach a single diff with all toghether (his last comment says he still misses a few strings from the first patch).
Also, RaceCondition, will you want to keep Estonian up-to-date?
Thanks

comment:10 by mrts, 17 years ago

RaceCondition is just now preparing a final translation that merges both translation files.

He will mark this ticket as ready for checkin when the translation is done. Before that neither of the translations should be merged.

I vote for RaceCondition to become the official Estonian translation maintainer.

by RaceCondition <eallik@…>, 17 years ago

Attachment: et.2.diff added

comment:11 by Erik Allik, 17 years ago

Merged diffs from myself and mrts, also fixed a few typos found during review.

comment:12 by Marc Fargas, 17 years ago

(In [7668]) Refs #7141, New Estonian translation. (Thanks Erik Allik & mrts)

comment:13 by Marc Fargas, 17 years ago

Triage Stage: AcceptedReady for checkin

Done, but I can't commit global_settings.py let's hope somebody who can can put the change.

by Marc Fargas, 17 years ago

Attachment: settings.diff added

Pending changes to global_settings.py

by RaceCondition <eallik@…>, 17 years ago

Attachment: et.3.diff added

Same as before with minor fixes and enhancements

comment:14 by Erik Allik, 17 years ago

I don't know why telenieko attached settings.diff with changes to global_settings.py because my patch already contains the same diff.

comment:15 by Erik Allik, 17 years ago

Nevermind that settings.diff question.

by RaceCondition <eallik@…>, 17 years ago

Attachment: et.4.diff added

comment:16 by Erik Allik, 17 years ago

Patch needs improvement: unset

comment:17 by Marc Fargas, 17 years ago

(In [7672]) Refs #7141, Estonian updates (Thanks Erik Allik)

comment:18 by Marc Fargas, 17 years ago

milestone: 1.0
Summary: Estonian translationEstonian translation missing in global_settings.py

comment:19 by Jacob, 17 years ago

(In [7697]) Added Estonian to global_settings.LANGUAGES. Refs #7141.

comment:20 by Marc Fargas, 17 years ago

Resolution: fixed
Status: newclosed

Thanks jacob! Closing now then.

comment:21 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top