#7141 closed (fixed)
Estonian translation missing in global_settings.py
Reported by: | mrts | Owned by: | nobody |
---|---|---|---|
Component: | Translations | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Attachments (7)
Change History (28)
by , 17 years ago
follow-up: 2 comment:1 by , 17 years ago
I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.
comment:2 by , 17 years ago
Triage Stage: | Unreviewed → Accepted |
---|
Replying to RaceCondition:
I've also just created the estonian translation. There are a bit more translations in my diff but I've skipped the localflavor region and similar translations.
What is alternative in the alternative patch? Or does it mean "improved"? (not everybody speaks Estonian) Knowing the difference between both diff will make things easier for mtredinnick when he comes back.
comment:3 by , 17 years ago
Three points for me for asking something answered on the quoted text of my reply... Forget my question!!!
by , 17 years ago
Attachment: | et.alt.2.diff added |
---|
comment:4 by , 17 years ago
The previous et.alt.diff file did not conform to the standard i18n diff file, so I've fixed it. Still haven't merged some translations that my diff is missing from the diff that mrts attached.
follow-up: 7 comment:5 by , 17 years ago
Patch needs improvement: | set |
---|
It should be decided who will maintain the Estonian translation. I'm willing to do it, but I am also happy to delegate maintenance to RaceCondition. What matters is a long-term commitment to improving the translation. I'm sure that I use and contribute to Django on regular basis in the foreseeable future, but it's up to RaceCondition to decide if we prefers to maintain it.
The maintainer should
- be accepted by Django i18n team (Malcolm?)
- do the discussed review and upload a final complete patch
- mark this ticket as ready for checkin and/or commit it to
et
tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).
comment:7 by , 17 years ago
Replying to mrts:
- be accepted by Django i18n team (Malcolm?)
Not really a requirement, you just have to take care of your .po file and try to keep it up-to-date.
- mark this ticket as ready for checkin and/or commit it to
et
tree in SVN (looks like translation maintainers get SVN access to the language tree they maintain).
Not exactly, translators which over time proved a willingness to maintain their languages and always were uploading clean and nice patches were gifted with commit rights on their locale's. But most of the languages still go trhought tickets, well event Catalan and Spanish still open tickets before been commited :)
follow-up: 9 comment:8 by , 17 years ago
Responding to Marc Fargas' call for translation reviews.
I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations. (Although first one has some problems in the beginning of the file -- don't know if that affects to merging.)
I'm not native speaker of Estonian so I cannot comment on details, but bot of there are legit translations.
comment:9 by , 17 years ago
Replying to Uninen:
I read trough both the et.alt.diff and et.alt.2.diff, which both seemed to be OK regarding to the translations.
Thanks a lot for the help!
Hope RaceCondition can attach a single diff with all toghether (his last comment says he still misses a few strings from the first patch).
Also, RaceCondition, will you want to keep Estonian up-to-date?
Thanks
comment:10 by , 17 years ago
RaceCondition is just now preparing a final translation that merges both translation files.
He will mark this ticket as ready for checkin when the translation is done. Before that neither of the translations should be merged.
I vote for RaceCondition to become the official Estonian translation maintainer.
by , 17 years ago
comment:11 by , 17 years ago
Merged diffs from myself and mrts, also fixed a few typos found during review.
comment:12 by , 17 years ago
comment:13 by , 17 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Done, but I can't commit global_settings.py let's hope somebody who can can put the change.
comment:14 by , 17 years ago
I don't know why telenieko attached settings.diff with changes to global_settings.py because my patch already contains the same diff.
by , 17 years ago
comment:16 by , 17 years ago
Patch needs improvement: | unset |
---|
comment:18 by , 17 years ago
milestone: | → 1.0 |
---|---|
Summary: | Estonian translation → Estonian translation missing in global_settings.py |
comment:20 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks jacob! Closing now then.
Patch against [7510]