Code

Opened 6 years ago

Closed 6 years ago

#7068 closed (fixed)

contrib.auth.forms are not i18n enabled

Reported by: pigletto Owned by: nobody
Component: Contrib apps Version: newforms-admin
Severity: Keywords: password auth reset
Cc: pigletto@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

AuthenticationForm, PasswordResetForm, PasswordChangeForm, AdminPasswordChangeForm have no 'label' set for it's fields, eg.:

password1 = forms.CharField(max_length=60, widget=forms.PasswordInput)

so field labels are not internationalized.
Patch is attached.

Would be nice if this can be applied with ticket 6905 http://code.djangoproject.com/ticket/6905.

Attachments (1)

auth_translations_v7436.diff (2.2 KB) - added by pigletto 6 years ago.
patch against svn version 7436

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by pigletto

patch against svn version 7436

comment:1 Changed 6 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Fixed on a branch

This has been fixed in the newforms-admin branch

comment:2 Changed 6 years ago by pigletto

Sorry but where is that fix? I can't see it fixed at newforms-admin branch, revision 7442:

http://code.djangoproject.com/browser/django/branches/newforms-admin/django/contrib/auth/forms.py?rev=7442

comment:3 Changed 6 years ago by Alex

  • Triage Stage changed from Fixed on a branch to Accepted

Whoops, boneheaded move on my part, it looks like those are only set on one of the forms(user creation).

comment:4 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7449]) newforms-admin: Fixed #6774, #7068 -- Use ugettext_lazy instead of ugettext in django/contrib/auth/forms.py. Marked a few strings for translation in the forms.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.