#6774 closed (fixed)
Use ugettext_lazy instead of ugettext in contrib.auth.forms
Reported by: | Honza Král | Owned by: | Brian Rosner |
---|---|---|---|
Component: | Contrib apps | Version: | newforms-admin |
Severity: | Keywords: | nfa-blocker auth ugettext | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently ugettext
is used in form fields' definitions. this breaks when the module is being impoerted during initialization (before the language is properly set).
The patch corrects the issue by using ugettext_lazy where appropriate.
Attachments (1)
Change History (6)
by , 17 years ago
Attachment: | 6774.nfa.diff added |
---|
comment:1 by , 17 years ago
Component: | Uncategorized → Contrib apps |
---|---|
Has patch: | set |
Owner: | changed from | to
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
Keywords: | nfa-blocker added |
---|
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 by , 17 years ago
In [7449] label "Email" was introduced but the documentation states that "E-mail" is the right way to write it.
Attached patch has the "E-mail" label. Is there a reason for not writing it that way?
Note:
See TracTickets
for help on using tickets.
This seems to be the right thing to do. It worked before because oldforms did this in its
__init__
which ran during view execution. Any particular reason for the usage of
ugettext
name over just
_
?