Atom Feed dates should use settings.TIME_ZONE

[mattdw]

Atom feeds currently only seem to format dates if the dates have attached timezone information. For some reason my dates don't (perhaps because I'm using SQLite as my backend.)

In settings.py I have: TIME_ZONE = 'Pacific/Auckland'

A comment object has date:

>>> c
<Comment: Matt: A test comment…>
>>> c.published
datetime.datetime(2008, 4, 14, 17, 46, 15, 24810)

the corresponding atom feed entry has date:

<updated>2008-04-14T17:46:15Z</updated>

There are two possible fixes that I can think of; either the correct offset should be calculated (e.g. 2008-04-14T17:46:15+12:00) or the time should be converted to UTC (e.g. 2008-04-15T03:46:15Z.

The rest of my website seems to handle dates and times fine (although I suspect it may be because it's not trying to do any TZ work at all, just displaying the dates as-is), which is why I've categorised it as a Feed Framework issue.

[Julian Bez]

I can confirm that the dates in atom feeds are somehow wrong, switched to RSS and everything works.
Should be fixed before 1.0

[ccahoon <chris.cahoon@…>]

I have verified the specs for both RSS 2.0 and Atom, and the date/time formats are correct now for both of these. It finds the difference between UTC and local time zones and appends that UTC offset correctly to the date/times of the feed entries.

I also had to modify the date formatting methods in utils/feedgenerator.py with custom string formats, because none of the existing ones were quite accurate for the feed specs.

[ccahoon <chris.cahoon@…>]

This time for sure.

[ccahoon <chris.cahoon@…>]

Nuked an important include fixing a typo, this is the working version

[ccahoon <chris.cahoon@…>]

Malcolm looked over my shoulder while I was writing this and preparing the patch. He says it's ready for checkin.

[Jacob]

Fixed in [8216].

[Jacob]

Milestone 1.0 beta deleted