Code

Opened 6 years ago

Closed 6 years ago

#6437 closed (wontfix)

get_karma_total() returns total Karma for an entire site, not for an associated comment.

Reported by: nh7a Owned by: nh7a
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

While Django's Karma is designed to give it to the comments, counting methods of get_karma_total(), get_good_karma_total(), and get_bad_karma_total() return the number for an entire site, not for the comments.

For instance, with the following typical usage of Krama counting methods, all goods and bads below ends up showing the same number for each.

{% for comment in comment_list %}
<div>
 <p>{{ comment.user }}</p>
 <p>{{ comment.comment }}</p>
 <p>Good ({{ comment.get_good_karma_total }})
    Bad ({{ comment.get_bad_karma_total }})</p>
</div>
{% endfor %}

Attachments (1)

karmacounting.diff (1.1 KB) - added by nh7a 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by nh7a

  • Status changed from new to assigned
  • Summary changed from get_karma_total() returns total for an entire site, not for an associated comment. to get_karma_total() returns total Karma for an entire site, not for an associated comment.

Changed 6 years ago by nh7a

comment:2 Changed 6 years ago by nh7a

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 6 years ago by nh7a

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 Changed 6 years ago by PJCrosier

  • Resolution set to wontfix
  • Status changed from reopened to closed

django.contrib.comments is up for a rewrite, so I'll be bold and mark this as wontfix - see James' response on #6651 and http://groups.google.com/group/django-developers/msg/503e43c0a71c6b8b

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.