Code

Opened 6 years ago

Closed 6 years ago

#6651 closed (wontfix)

django.contrib.comments Manipulators Automatically strip() Whitespace

Reported by: jeff@… Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: whitespace comments
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In my opinion, the manipulator should not modify the contents of the comment. When submitting content, currently, the spaces at the beginning and end get pulled off, which is especially annoying when using Markdown, which treats leading whitespace differently (four spaces creates a blockquote).

I suppose it's acceptable to strip all non-content fields (headline, name, etc.), but comment should not be modified.

Attachments (2)

patch.diff (1.1 KB) - added by jeff@… 6 years ago.
Patch
patch.2.diff (1.2 KB) - added by jeff@… 6 years ago.
Updated patch (with full path)

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by jeff@…

Patch

Changed 6 years ago by jeff@…

Updated patch (with full path)

comment:1 Changed 6 years ago by ubernostrum

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Given that the whole thing needs to be rewritten for newforms before 1.0, I'd rate it unlikely that a patch such as this is useful right now.

comment:2 Changed 6 years ago by jeff@…

I recognize that, but it seems ugly in the meantime. Are there going to be no more .9x releases?

comment:3 Changed 6 years ago by ubernostrum

It's almost certain at this point that any future release will finish the conversion to newforms. Whether that release is called "1.0" or not is up for debate, but it feels likely.

comment:4 Changed 6 years ago by jeff@…

Fair enough. I guess you may close this if you like. (In the meantime, I'll use my modified comments. :) ).

comment:5 Changed 6 years ago by Simon Greenhill

  • Resolution set to wontfix
  • Status changed from new to closed

Please create a new ticket if this is still a problem after refactoring.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.