Opened 16 years ago
Closed 16 years ago
#6651 closed (wontfix)
django.contrib.comments Manipulators Automatically strip() Whitespace
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | whitespace comments | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In my opinion, the manipulator should not modify the contents of the comment. When submitting content, currently, the spaces at the beginning and end get pulled off, which is especially annoying when using Markdown, which treats leading whitespace differently (four spaces creates a blockquote).
I suppose it's acceptable to strip all non-content fields (headline, name, etc.), but comment should not be modified.
Attachments (2)
Change History (7)
by , 16 years ago
| Attachment: | patch.diff added |
|---|
comment:1 by , 16 years ago
Given that the whole thing needs to be rewritten for newforms before 1.0, I'd rate it unlikely that a patch such as this is useful right now.
comment:2 by , 16 years ago
I recognize that, but it seems ugly in the meantime. Are there going to be no more .9x releases?
comment:3 by , 16 years ago
It's almost certain at this point that any future release will finish the conversion to newforms. Whether that release is called "1.0" or not is up for debate, but it feels likely.
comment:4 by , 16 years ago
Fair enough. I guess you may close this if you like. (In the meantime, I'll use my modified comments. :) ).
comment:5 by , 16 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Please create a new ticket if this is still a problem after refactoring.
Patch